Project: chromium Issues People Development process History Sign in
New issue
Advanced search Search tips
Issue 703030 Regression:Text message is missing in zoomLevels page for Md-settings
Starred by 2 users Project Member Reported by ratnavar...@techmahindra.com, Mar 20 Back to list
Status: Fixed
Owner:
Closed: Mar 20
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux, Windows, Mac
Pri: 1
Type: Bug-Regression



Sign in to add a comment
Chrome Version:59.0.3046.0 dev
OS:Ubuntu 14.04,Windows

What steps will reproduce the problem?
(1)Launch chrome,goto chrome://md-settings/content/zoomLevels and Observe.

Actual:"No sites have been zoomed in or out" message is missing in the zoom levels page.
Expected:Instead,"No sites have been zoomed in or out"message should appear.

This is a regression issue broken in M-59

Manual Bisect Info:
===================
Good Build:59.0.3042.0 dev
Bad Build :59.0.3043.0 dev






 
ACtual.png
96.4 KB View Download
Expected.png
99.0 KB View Download
Cc: rbasuvula@chromium.org
Labels: -Needs-Bisect hasbisect-per-revision OS-Mac
Owner: dpa...@chromium.org
Status: Assigned
Using the per-revision bisect providing the bisect results,
Good build:59.0.3042.0 (Revision:456934).
Bad build:59.0.3043.0 (Revision:457297).

You are probably looking for a change made after 457183 (known good), but no later than 457184 (first known bad).

CHANGE-LOG URL:
---------------
https://chromium.googlesource.com/chromium/src/+log/99567cf4a49bc6e5b58b58ca3ace741194f08a8e..a46bc7937ac5efb5d990fb5c49c519b21e037403

From the CL above, assigning the issue to the concern owner

@dpapad : Could you please look into the issue, pardon me if it has nothing to do with your changes and if possible please assign it to concern owner.

Review-Url:https://codereview.chromium.org/2738063008
Note :Able to reproduce the issue in Win 10.0,Ubuntu 14.04 & Mac 10.12.3 and Able to reproduce in latest Canary #59.0.3046.0
Labels: Proj-MaterialDesign-WebUI
Status: Started
Project Member Comment 4 by bugdroid1@chromium.org, Mar 20
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/faa75b549b2c1395e4fb633ff68551d0dd70ddae

commit faa75b549b2c1395e4fb633ff68551d0dd70ddae
Author: dpapad <dpapad@chromium.org>
Date: Mon Mar 20 22:23:40 2017

MD Settings: Restore message shown when no "zoom" exceptions exist.

BUG= 703030 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2757333003
Cr-Commit-Position: refs/heads/master@{#458202}

[modify] https://crrev.com/faa75b549b2c1395e4fb633ff68551d0dd70ddae/chrome/browser/resources/settings/site_settings/zoom_levels.html
[modify] https://crrev.com/faa75b549b2c1395e4fb633ff68551d0dd70ddae/chrome/test/data/webui/settings/zoom_levels_tests.js

Status: Fixed
Labels: TE-Verified-M59 TE-Verified-59.0.3047.0
Tested the issue on Windows-7,Mac 10.12.3 and Linux Ubuntu-14.04 using Chrome version 59.0.3047.0 as per the comment #0.
Observed that the fix is working as expected.Hence adding the verified labels.

Please find the attached screen cast for reference.

Thanks.
Win-703030.mp4
299 KB View Download
Sign in to add a comment