Fake omnibox disappears on navigating back from incognito mode |
|||||||||
Issue descriptionApp Version: 58.0.3029.25 dev iOS Version: 9.3.5,iOS 10 Device : iPhones only Precondition: 1. Have few Most visited icons in NTP. Steps to reproduce: 1. Launch chrome. 2. Tap on Fake omni box and go to full screen. 3. Long tap on any most visited icon > tap on open in New incognito tab. 4. Tab on tab switcher and navigate back to normal mode. Observed results: Fake omni box disappears. Expected results: Fake omnibox should be displayed. Number of times you were able to reproduce: 5/5 Bug reproducible after clean install: Yes Bug reproducible after clearing cache and cookies: Yes Bug reproducible on Chrome Mobile on Android: NA Bug reproducible on Dolphin/Safari/Firefox: Safari : NA Bug reproducible on current stable build (App Version, iOS Version): Yes in M57 Bug reproducible on the current beta channel build (App Version, iOS Version): Yes in M58 Link to Video : https://drive.google.com/a/google.com/file/d/0B--UpU2GW2EpczZYdWlPRE1TU3c/view?usp=sharing
,
Mar 20 2017
,
Jun 26 2017
This seems annoying. Is there an update on this bug?
,
Oct 12 2017
,
Dec 7 2017
,
Aug 7
,
Aug 7
,
Aug 22
,
Aug 23
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/cdb52dbecd02a7ca0598c9d6de2f90d23b3eb042 commit cdb52dbecd02a7ca0598c9d6de2f90d23b3eb042 Author: Justin Cohen <justincohen@google.com> Date: Thu Aug 23 13:51:51 2018 [ios] Don't hide fake omnibox on real omnibox focus. For historical reference, four years we started hiding this view "to prevent it from overlapping slightly with Most Visited after a device rotation when the omnibox is focused." per: https://chromereviews.googleplex.com/99937015 It doesn't appear this is necessary anymore, and hiding that view is causing some edge case bugs. Bug: 703024 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: Icb43e4a93b3e1675684267e2b8f4433a47acad17 Reviewed-on: https://chromium-review.googlesource.com/1185742 Reviewed-by: Justin Cohen <justincohen@chromium.org> Reviewed-by: Gauthier Ambard <gambard@chromium.org> Commit-Queue: Justin Cohen <justincohen@chromium.org> Cr-Commit-Position: refs/heads/master@{#585471} [modify] https://crrev.com/cdb52dbecd02a7ca0598c9d6de2f90d23b3eb042/ios/chrome/browser/ui/content_suggestions/content_suggestions_header_view_controller.mm
,
Aug 23
,
Aug 24
FYI, this change reverts the fix to https://bugs.chromium.org/p/chromium/issues/detail?id=489121, which shouldn't be necessary with UI Refresh.
,
Aug 29
Verified in: App Version: 70.0.3535.0 canary Devices: iPhone 6 Plus, iPhone 8, iPhone X iOS Versions: 10.3.3, 11.4.1 Fake omnibox is displayed on navigating back from incognito mode. Video: https://drive.google.com/open?id=1dMDTweWrQfgEWpcYC-9_QV8aicTVZ0fq |
|||||||||
►
Sign in to add a comment |
|||||||||
Comment 1 by pmadalla@chromium.org
, Mar 20 2017