New issue
Advanced search Search tips

Issue 703016 link

Starred by 2 users

Issue metadata

Status: Assigned
Owner:
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux
Pri: 1
Type: Bug



Sign in to add a comment

V8 correctness failure in configs: x64,ignition_turbo_opt:x64,ignition_turbo_opt_eager

Project Member Reported by ClusterFuzz, Mar 20 2017

Issue description

Cc: machenb...@chromium.org
Owner: marja@chromium.org
Status: Assigned (was: Untriaged)
This is a difference between lazy and no-lazy parsing. The minimized version of the repro ...

$ cat test/mjsunit/foo.js
function f() {
  eval("(dup, {a: dup}) => {};");
}
f();

The difference can be observed by running with these two command line flags:

$ ./out/x64.debug/d8 test/mjsunit/foo.js 
$ ./out/x64.debug/d8 test/mjsunit/foo.js --no-lazy

Comment 2 by marja@chromium.org, Mar 21 2017

Yup, this is the known case that PreParser doesn't find duplicates in arrow func param lists when the duplicates come from destructuring. (See e.g https://bugs.chromium.org/p/v8/issues/detail?id=6108 )

We'd probably want to suppress these cases.

This is a probably simpler repro:

function f() {
  (dup, {a: dup}) => {};
}

Afaics the eval is not relevant.
Project Member

Comment 3 by ClusterFuzz, May 16 2017

ClusterFuzz has detected this issue as fixed in range 45316:45317.

Detailed report: https://clusterfuzz.com/testcase?key=4854349890322432

Fuzzer: foozzie_js_mutation
Job Type: v8_foozzie
Platform Id: linux

Crash Type: V8 correctness failure
Crash Address: 
Crash State:
  configs: x64,ignition_turbo_opt:x64,ignition_turbo_opt_eager
  sources: 73b
  
Sanitizer: address (ASAN)

Regressed: V8: 43591:43592
Fixed: V8: 45316:45317

Reproducer Testcase: https://clusterfuzz.com/download?testcase_id=4854349890322432


See https://dev.chromium.org/Home/chromium-security/bugs/reproducing-clusterfuzz-bugs for more information.

If you suspect that the result above is incorrect, try re-doing that job on the test case report page.
Project Member

Comment 4 by ClusterFuzz, May 16 2017

Labels: ClusterFuzz-Verified
Status: Verified (was: Assigned)
ClusterFuzz testcase 4854349890322432 is verified as fixed, so closing issue.

If this is incorrect, please add ClusterFuzz-Wrong label and re-open the issue.
Labels: ClusterFuzz-Wrong
Status: Assigned (was: Verified)
Labels: -ClusterFuzz-Wrong
We have made a bunch of changes on ClusterFuzz side, so resetting ClusterFuzz-Wrong label.
Project Member

Comment 7 by ClusterFuzz, Oct 19 2017

ClusterFuzz has detected this issue as fixed in range 48714:48715.

Detailed report: https://clusterfuzz.com/testcase?key=4854349890322432

Fuzzer: foozzie_js_mutation
Job Type: v8_foozzie
Platform Id: linux

Crash Type: V8 correctness failure
Crash Address: 
Crash State:
  configs: x64,ignition_turbo_opt:x64,ignition_turbo_opt_eager
  sources: 73b
  
Sanitizer: address (ASAN)

Regressed: https://clusterfuzz.com/revisions?job=v8_foozzie&range=43591:43592
Fixed: https://clusterfuzz.com/revisions?job=v8_foozzie&range=48714:48715

Reproducer Testcase: https://clusterfuzz.com/download?testcase_id=4854349890322432

See https://github.com/google/clusterfuzz-tools for more information.

If you suspect that the result above is incorrect, try re-doing that job on the test case report page.
Labels: -ClusterFuzz-Verified ClusterFuzz-Wrong
Labels: -v8-foozzie-failure
Removing v8-foozzie-failure label, because eager-lazy testing has been removed from correctness-fuzzer experiments.

Sign in to add a comment