New issue
Advanced search Search tips

Issue 703002 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Apr 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux
Pri: 2
Type: Bug



Sign in to add a comment

A nonsense "==$0" appears next to the selected node in the Elements inspector

Reported by teo8...@gmail.com, Mar 19 2017

Issue description

UserAgent: Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/57.0.2987.110 Safari/537.36

Steps to reproduce the problem:
1. open any webpage 
2. right-click "Inspect Element"

What is the expected behavior?

What went wrong?
Next to the selected node in the Elements inspector, there is a nonsense sequence of characters "==$0".

Did this work before? N/A 

Chrome version: 57.0.2987.110  Channel: stable
OS Version: 
Flash Version: Shockwave Flash 25.0 r0
 
Untitled.png
36.0 KB View Download

Comment 1 by woxxom@gmail.com, Mar 20 2017

Well, this hint is kinda nonsensical indeed, but the intentions were good!
It promotes the indispensible feature of using $0, $1, etc. in the console:
https://developers.google.com/web/tools/chrome-devtools/console/expressions#access_recently_selected_elements_and_objects
Cc: rbasuvula@chromium.org
Labels: Needs-Feedback
Tested in chrome # 57.0.2987.110 and Canary #59.0.3046.0 on Ubuntu 14.04 and able to reproduce the issue.Please find the screen shots for your reference.

@ teo8976 : Could you please let me know if i have missed anything and if possible, provide us with a expected behaviour of the issue which would help us to triage the issue further.

Thanks in Advance.
703002.png
133 KB View Download

Comment 3 by ja...@apphaus.co.uk, Mar 20 2017

I wonder if the reporter is aware of the feature in Comment 1.

If the essence of the issue is to improve the display of "==$0" to make it clearer, rather than to remove it, then this is fairly similar to an old issue from last year 582439.

Comment 4 by teo8...@gmail.com, Mar 20 2017

> I wonder if the reporter is aware of the feature in Comment 1.

No I was not. I genuinely thought it was being displayed by accident.

That said, I still wonder wether it makes sense. If $0 is always the currently selected element, given that the currently selected element is already highlighted, what additional information does displaying "==$0" next to it provide?? Does it make the feature more discoverable? No it doesn't. 

If I understand correctly, $1 would be the previous selected element, $2 the previous-previous one and so on up to $4. So, if you were displaying also "==$1".."==$4" (or just $1..$4 or whatever) next to all the recent elements, that would actually be useful (to people who already know about the feature; to those who don't none of this is going to be of any use), but that doesn't seem to be the case.
Project Member

Comment 5 by sheriffbot@chromium.org, Mar 20 2017

Labels: -Needs-Feedback
Thank you for providing more feedback. Adding requester "rbasuvula@chromium.org" to the cc list and removing "Needs-Feedback" label.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Owner: l...@chromium.org
Status: Assigned (was: Unconfirmed)
@luoe, maybe we should have a better way to introduce people into $0
Maybe add a tooltip to the `$0` which says something to the effect of "Use $0 in console for this element."?

Comment 8 by l...@chromium.org, Mar 24 2017

Screenshots of a proposal, '== $0 in console' with tooltip 'Use $0, $1, $2, $3, $4 in the console to refer to selected elements.'
beforeAfterDollarZero.png
71.4 KB View Download
beforeAfterDollarZero2.png
143 KB View Download
== $0 in console looks too verbose to me. also click is not expected on the hint

Comment 10 by teo8...@gmail.com, Mar 24 2017

- I still don't understand why $1..$2 are not shown, when they are the ones that would actually be useful (am I supposed to remember which elements were selected before??)
- The "==" is totally superflous, especially if you're going to add "in console"... but even without that.
- "click is not expected on the hint": I guess the proposal is to show the tooltip on rollover, not on click. Which seems fine, except for the fact that it can become quite annoying if it pops up all the time when you hover the selected element. Some way of dismissing it and have it never show up again is mandatory.
- "selected elements" is unclear. You cannot select more than one element (which sucks btw). It should read something like "recently selected elements"

Comment 11 by l...@chromium.org, Mar 24 2017

We can make the tooltip apply only when the '== $0' is hovered, not the entire element.  Concise text like in comment #7 sounds good to me.  Keeping it clear without introducing too much noise.
Project Member

Comment 12 by bugdroid1@chromium.org, Apr 4 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ebbfebff49abb37df9789e93cb1feb29dd399941

commit ebbfebff49abb37df9789e93cb1feb29dd399941
Author: luoe <luoe@chromium.org>
Date: Tue Apr 04 22:06:53 2017

DevTools: improve $0 selected element hint in elements

This adds a tooltip on the '== $0' hint explaining what it is for.

BUG= 703002 

Review-Url: https://codereview.chromium.org/2770743004
Cr-Commit-Position: refs/heads/master@{#461860}

[modify] https://crrev.com/ebbfebff49abb37df9789e93cb1feb29dd399941/third_party/WebKit/Source/devtools/front_end/elements/ElementsTreeElement.js
[modify] https://crrev.com/ebbfebff49abb37df9789e93cb1feb29dd399941/third_party/WebKit/Source/devtools/front_end/elements/elementsTreeOutline.css

Comment 13 by l...@chromium.org, Apr 5 2017

Status: Fixed (was: Assigned)

Sign in to add a comment