Regression: [chrome://settings/syncSetup] Under "Choose What To Sync", Missing 6 Checkboxes
Reported by
ejmar...@gmail.com,
Mar 19 2017
|
||||||
Issue descriptionUserAgent: Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/59.0.3043.0 Safari/537.36 Steps to reproduce the problem: 1. Goto chrome://settings/ 2. Click on "Advanced sync settings..." 3. Select "Choose what to sync" What is the expected behavior? There should be 10 Checkboxes (1 for each) for: 1) Apps 2) Autofill 3) Bookmarks 4) Credit cards and addresses using Google Payments 5) Extensions 6) History 7) Passwords 8) Settings 9) Themes 10) Open Tabs What went wrong? Only 4 out of 10 of the items have checkboxes (1 - 4). Most of the items (5 - 10) are missing the usual checkboxes. Did this work before? Yes 58.0.3029.19 (Previous Version and all versions prior to that) Chrome version: 59.0.3043.0 Channel: dev OS Version: openSUSE Tumbleweed - Version 20170316 Flash Version: 25.0.0.127
,
Mar 20 2017
,
Mar 21 2017
Able to reproduce the issue on windows-7,Mac-10.12.3 and Linux Ubuntu-14.04 using chrome canary 59.0.3046.0. This is regression issue broken in M59.Please find the bisect information as below Narrow Bisect:: =============== Good::59.0.3042.0 -- (build revision 456934) Bad ::59.0.3043.0 -- (build revision 457297) ChangeLog: ================ https://chromium.googlesource.com/chromium/src/+log/8fd773268f69e868b3f57b90708709c4b085e9cb..bfc4d20f79563dd15832c9f77a4cb916476f3b7c Review-Url: https://codereview.chromium.org/2748973002 mstensho@could you please look into this issue if it is related to your change,else please help us in finding the appropriate owner for this issue. Thanks,
,
Mar 21 2017
,
Mar 22 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/f41660904d869f6d30fa31f75ca6d6072202d9a1 commit f41660904d869f6d30fa31f75ca6d6072202d9a1 Author: mstensho <mstensho@opera.com> Date: Wed Mar 22 17:01:16 2017 No default value for AncestorSearchConstraint in locateFlowThreadContainingBlockOf(). The default used to be to bail out and return nullptr if it encountered something unbreakable. It's better to let callers make a conscious choice here. Tree-read operations (painting or hit testing, for instance) that call LayoutObject::locateFlowThreadContainingBlock() are typically interested in converting from flow thread coordinates to visual coordinates. This is a defensive CL that only reverts unintended and bad changes from https://codereview.chromium.org/2748973002 - added a TODO for cases where we have LayoutState; if we are inside of layout, we should ideally stop at strictly unbreakable ancestors. BUG= 702978 Review-Url: https://codereview.chromium.org/2764883004 Cr-Commit-Position: refs/heads/master@{#458784} [add] https://crrev.com/f41660904d869f6d30fa31f75ca6d6072202d9a1/third_party/WebKit/LayoutTests/fast/multicol/relpos-inside-inline-block-expected.html [add] https://crrev.com/f41660904d869f6d30fa31f75ca6d6072202d9a1/third_party/WebKit/LayoutTests/fast/multicol/relpos-inside-inline-block.html [modify] https://crrev.com/f41660904d869f6d30fa31f75ca6d6072202d9a1/third_party/WebKit/Source/core/layout/LayoutFlowThread.h [modify] https://crrev.com/f41660904d869f6d30fa31f75ca6d6072202d9a1/third_party/WebKit/Source/core/layout/LayoutObject.cpp
,
Mar 22 2017
,
Mar 28 2017
Tested the issue on windows 7, Mac 10.12.3, Linux Ubuntu 14.04 using chrome version#59.0.3053.3 with the steps mentioned in comment #0.Observed that the above mentioned 10 checkboxes displayed properly upon clicking "Choose what to sync" button in 'advanced settings.Hence adding TE-Verified labels. Please find the attached screen cast for the same. Thanks!! |
||||||
►
Sign in to add a comment |
||||||
Comment 1 by pkalinnikov@chromium.org
, Mar 20 2017