New issue
Advanced search Search tips

Issue 702973 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner: ----
Closed: Mar 2017
Components:
EstimatedDays: ----
NextAction: ----
OS: Mac
Pri: 2
Type: Bug



Sign in to add a comment

Service Worker "Update on reload" warning does not clearly describe where the checkbox is

Reported by ja...@apphaus.co.uk, Mar 19 2017

Issue description

UserAgent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_12_3) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/57.0.2987.98 Safari/537.36

Steps to reproduce the problem:
1. Turn on 'Update on reload' in DevTools Service Workers pane, in the Application Panel
2. Refresh the page several times
3. Observe the wording around the "Update on load" checkbox option and where it is located in Dev Tools

What is the expected behavior?
1. The name of the option in the warning ("Update on load") is consistent with the name of the option in Dev Tools ("Update on reload")
2. The location of the option in the warning ("in DevTools Service Workers toolbar") is consistent with the location of the option in Devtools ("in the DevTools Service Workers pane[a] in the Application panel[b].")

Precedent for the use of the term "The Service Workers pane in the Application panel": https://developers.google.com/web/tools/chrome-devtools/progressive-web-apps

What went wrong?
The warning wording is a little unclear as to where the option is in DevTools, and what the checkbox is called.

Did this work before? N/A 

Chrome version: 57.0.2987.98  Channel: n/a
OS Version: OS X 10.12.3
Flash Version: Shockwave Flash 25.0 r0
 
Screen Shot 2017-03-19 at 4.01.30 PM.png
46.4 KB View Download
Labels: Needs-Triage-M57
Project Member

Comment 3 by bugdroid1@chromium.org, Mar 21 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f1aa486c25eb37a418e32d1f00ef43ed1d98f60a

commit f1aa486c25eb37a418e32d1f00ef43ed1d98f60a
Author: james <james@apphaus.co.uk>
Date: Tue Mar 21 21:07:59 2017

DevTools: Clarify Service Worker 'Update on reload' location in warning

A console warning is displayed if 'Update on reload' is checked in the
DevTools Service Worker pane. This CL updates the wording to clarify
where the 'Update on reload' option can be found in DevTools.

BUG= 702973 

Review-Url: https://codereview.chromium.org/2762523002
Cr-Commit-Position: refs/heads/master@{#458545}

[modify] https://crrev.com/f1aa486c25eb37a418e32d1f00ef43ed1d98f60a/content/browser/service_worker/service_worker_version.cc

Status: Fixed (was: Unconfirmed)

Comment 5 by kayce@google.com, Mar 24 2017

It would be cool if "Service Worker pane" was a link that jumped you to that pane!

Sign in to add a comment