New issue
Advanced search Search tips

Issue 702971 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner: ----
Closed: Apr 2018
Components:
EstimatedDays: ----
NextAction: ----
OS: Mac
Pri: 3
Type: Bug
Team-Accessibility



Sign in to add a comment

Extension preferences and Keyboard shortcuts dialogs are not accessible

Reported by patrickw...@gmail.com, Mar 19 2017

Issue description

UserAgent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_11_6) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/56.0.2924.87 Safari/537.36

Steps to reproduce the problem:
1. Use a screen-reader 
2. Navigate the options for any extension
3. Navigate the keyboard shortcuts

What is the expected behavior?
I would expect the overlay dialog boxes to be accessible so that when navigating around them, the options are read by the screen reader.

What went wrong?
The screen reader cannot see any of the options.

The problem appears to be that when these overlays are 'shown', the ARIA-HIDDEN="true" attribute is not toggled along with the 'visibility'.

Here is a video of the problem: http://www.nklein.com/wp-content/uploads/2017/03/ChromeVoiceOverProblem.mp4

Did this work before? N/A 

Chrome version: 56.0.2924.87  Channel: stable
OS Version: OS X 10.11.6
Flash Version: 

I am working on a patch for this.  It looks to be straightforward.  But, it is unclear to me how I will submit it once I am done.
 
I have reported this twice with the "Report and issue..." link in the browser, but I cannot find either of those when I search here, so I added it again.  I hope I am not bombarding anyone with this bug.
Components: -UI UI>Accessibility
Labels: -Pri-2 Pri-3
Status: Available (was: Unconfirmed)

Comment 3 Deleted

Submitted a patch for this: https://codereview.chromium.org/2765493002
Labels: NewComponent-Accessibility NewComponent-Accessibility-Browser
Project Member

Comment 6 by bugdroid1@chromium.org, Mar 30 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c773631198a95466aa396f0b978c033626133bb8

commit c773631198a95466aa396f0b978c033626133bb8
Author: patrickwonders <patrickwonders@gmail.com>
Date: Thu Mar 30 12:43:16 2017

Fixing accessibility bug with extensions preferences

As reported in  bug 702971 :
   https://bugs.chromium.org/p/chromium/issues/detail?id=702971

The 'Keyboard shortcuts' and extension 'options' panels on the
extensions page are not accessible.  The code was trying to use the
'ARIA-HIDDEN' attribute to keep extension options hidden until it was
time to expose them.  However, there was a small bug in the exposing
code that resulted in the 'ARIA-HIDDEN' being set to 'TRUE' for all
panels (or, in some cases, 'FALSE' for all panels.

This is my first patch.  If someone could request a try job for me on this, I would appreciate it.

BUG= 702971 

TEST=Using a screenreader, navigate extension options and keyboard
shortcuts options for extensions. Before this patch, the screenreader
says nothing about what control it is on. After this patch, the
screenreader reads the panel text as appropriate.
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2765493002
Cr-Commit-Position: refs/heads/master@{#460734}

[modify] https://crrev.com/c773631198a95466aa396f0b978c033626133bb8/AUTHORS
[modify] https://crrev.com/c773631198a95466aa396f0b978c033626133bb8/chrome/browser/resources/extensions/extension_options_overlay.html
[modify] https://crrev.com/c773631198a95466aa396f0b978c033626133bb8/chrome/browser/resources/extensions/extensions.js
[modify] https://crrev.com/c773631198a95466aa396f0b978c033626133bb8/chrome/browser/ui/webui/extensions/extension_settings_browsertest.js

Labels: -newcomponent-accessibility-browser -newcomponent-accessibility
Project Member

Comment 8 by sheriffbot@chromium.org, Apr 23 2018

Labels: Hotlist-Recharge-Cold
Status: Untriaged (was: Available)
This issue has been Available for over a year. If it's no longer important or seems unlikely to be fixed, please consider closing it out. If it is important, please re-triage the issue.

Sorry for the inconvenience if the bug really should have been left as Available.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Status: Fixed (was: Untriaged)
Marking as fixed per #6.

Sign in to add a comment