in "Find" (Ctrl + F), scrolling is not smooth/animated when you click the "Next" arrow or "Enter" on your keyboard
Reported by
billdill...@gmail.com,
Mar 19 2017
|
||||||||||||||||||||
Issue descriptionUserAgent: Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/57.0.2987.110 Safari/537.36 Steps to reproduce the problem: I found an area where smooth scrolling is missing. Go to https://en.wikipedia.org/wiki/Ferrari, click "Find" and type "ferrari", now keep clicking the "Next" downward pointing arrow (or keep pressing Enter on your keyboard) until it starts scrolling down the page highlighting the occurrences of "ferrari": it doesn't scroll down the page smoothly, it just skips down the page abruptly. The scrolling should be smooth here if possible, it would be a nice little improvement to the "Find" experience What is the expected behavior? What went wrong? see above Did this work before? N/A Chrome version: 57.0.2987.110 Channel: stable OS Version: 10.0 Flash Version: Shockwave Flash 25.0 r0 Chrome does a really great job of "smooth scrolling" now across the browser, it even uses smooth scrolling when you press the "Home" or "End" keys, it should scroll smoothly whenever possible, including this "Find" scenario
,
Mar 20 2017
,
Mar 20 2017
Tested in chrome # 57.0.2987.110 and Canary #59.0.3046.0 on windows 10.0 and able to reproduce the issue.Please find the screen cast for your reference. @ billdillensrevenge : Could you please let me know if i have missed anything and if possible, provide us with a expected behavior of the issue which would help us to triage the issue further. Thanks in Advance.
,
Mar 20 2017
Do you see as its moving/scrolling down the page to highlight the occurrences of "ferrari" that there is no animation/transition as it moves down the page, it just abruptly skips to it, which makes it harder for your eyes to keep track. I'm proposing that instead of just abruptly skipping down the page, it has a smooth animation/transition (like smooth scrolling)
,
Mar 20 2017
Thank you for providing more feedback. Adding requester "rbasuvula@chromium.org" to the cc list and removing "Needs-Feedback" label. For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Mar 22 2017
,
Mar 22 2017
Tested the issue on chrome Stable #57.0.2987.110, Canary 59.0.3048.0 in Windows 10.0 & 7 and was able to reproduce the issue. This is a Non-Regression issue since seeing this from M35 #35.0.1898.0, Making the status to Untriaged so that the issue would get addressed. With respect to the label added: Needs-triage-Mobile, triaged the issue and below are the observations. Able to reproduce the issue on Mobile device (Handset) as per steps provided. Layout of the website looks fine both in normal mode and using the option "Request Desktop Mode". Devices Used: ============= Device: Nexus5 Chrome Version: 57.0.2987.110 Android version: 7.0.99/MRA20 Note : Able to reproduce the issue in MAC 10.12 and Linux Ubuntu 14.04. Thank you!
,
Mar 23 2017
This would be nice to have but not necessarily high-priority. sunyunjia@, I suspect this wouldn't be much work - perhaps you can find some time in between your CSS smooth scroll work.
,
Mar 23 2017
,
Mar 23 2017
My friend says he thinks Safari does this, anyone have access to a Mac or iOS device to check?
,
Mar 27 2017
,
Mar 28 2017
Adding the OS details.
,
Mar 28 2017
This applies to all OSes
,
Mar 28 2017
I was just able to check this on Safari on an iPhone and it does indeed do this smooth scrolling, so it would be nice to match Safari
,
Jun 13 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/e790c147386fdd83a00c71b62a54908a73a27dd6 commit e790c147386fdd83a00c71b62a54908a73a27dd6 Author: sunyunjia <sunyunjia@chromium.org> Date: Tue Jun 13 20:35:23 2017 "Find" scrolling should be smoothly animated. Previously, when we "Find" (Ctr + F) something in the webpage, the page abruptly scrolls the element into view, which makes it harder for users' eyes to keep track. As Safari is using smooth scroll for the "Find" feature, we implement this feature by setting the ScrollBehavior as "smooth" when calling scrollRectoToVisible(). BUG=702966 Review-Url: https://codereview.chromium.org/2935813002 Cr-Commit-Position: refs/heads/master@{#479133} [modify] https://crrev.com/e790c147386fdd83a00c71b62a54908a73a27dd6/third_party/WebKit/Source/core/dom/Element.cpp [modify] https://crrev.com/e790c147386fdd83a00c71b62a54908a73a27dd6/third_party/WebKit/Source/core/editing/Editor.cpp [modify] https://crrev.com/e790c147386fdd83a00c71b62a54908a73a27dd6/third_party/WebKit/Source/core/layout/LayoutBox.cpp [modify] https://crrev.com/e790c147386fdd83a00c71b62a54908a73a27dd6/third_party/WebKit/Source/core/layout/LayoutBox.h [modify] https://crrev.com/e790c147386fdd83a00c71b62a54908a73a27dd6/third_party/WebKit/Source/web/tests/SmoothScrollTest.cpp
,
Jun 13 2017
,
Jun 14 2017
Was this change approved in UX review? I find this to be a significant regression in Chrome's usability. I now have to sit and watch Chrome scroll through a page as I Ctrl-G my way through Find in Page results (on Windows). I very, very strongly prefer to have Chrome warp me to the next result.
,
Jun 14 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/e904789cbf296d563ebe5ce0a8c8414f9da41d2f commit e904789cbf296d563ebe5ce0a8c8414f9da41d2f Author: scottmg <scottmg@chromium.org> Date: Wed Jun 14 16:44:47 2017 Revert of "Find" scrolling should be smoothly animated. (patchset #3 id:40001 of https://codereview.chromium.org/2935813002/ ) Reason for revert: I believe this is a usability regression on desktop. Please reconsider, and perhaps it should be a mobile-only feature if it's an attempt to copy iOS Safari. Original issue's description: > "Find" scrolling should be smoothly animated. > > Previously, when we "Find" (Ctr + F) something in the webpage, the page > abruptly scrolls the element into view, which makes it harder for users' eyes > to keep track. As Safari is using smooth scroll for the "Find" feature, we > implement this feature by setting the ScrollBehavior as "smooth" when calling > scrollRectoToVisible(). > > BUG=702966 > > Review-Url: https://codereview.chromium.org/2935813002 > Cr-Commit-Position: refs/heads/master@{#479133} > Committed: https://chromium.googlesource.com/chromium/src/+/e790c147386fdd83a00c71b62a54908a73a27dd6 TBR=bokan@chromium.org,sunyunjia@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=702966 Review-Url: https://codereview.chromium.org/2942673002 Cr-Commit-Position: refs/heads/master@{#479419} [modify] https://crrev.com/e904789cbf296d563ebe5ce0a8c8414f9da41d2f/third_party/WebKit/Source/core/dom/Element.cpp [modify] https://crrev.com/e904789cbf296d563ebe5ce0a8c8414f9da41d2f/third_party/WebKit/Source/core/editing/Editor.cpp [modify] https://crrev.com/e904789cbf296d563ebe5ce0a8c8414f9da41d2f/third_party/WebKit/Source/core/layout/LayoutBox.cpp [modify] https://crrev.com/e904789cbf296d563ebe5ce0a8c8414f9da41d2f/third_party/WebKit/Source/core/layout/LayoutBox.h [modify] https://crrev.com/e904789cbf296d563ebe5ce0a8c8414f9da41d2f/third_party/WebKit/Source/web/tests/SmoothScrollTest.cpp
,
Jun 14 2017
One more note: I've got macOS Sierra (10.2.5) and Safari (10.1.1) and I do not see the referenced smooth scrolling behavior. The scrolling behavior is snap to word with a lightbox on the find term. iPhone does perform the smooth scrolling behavior, but whether or not it should be the Chrome Desktop behavior is questionable.
,
Jun 14 2017
No, sorry, that's my fault - I hadn't thought through the UX consequences here. sunyunjia@ lets roll back for now. We should find someone from UX to work out how/if we should reland this.
,
Jun 14 2017
,
Jun 14 2017
Beyond the user experience change and differing user opinions about it, I believe the CL in comment #15 is the cause regression Issue 733290 .
,
Jun 14 2017
People that don't like smooth scrolling should be given the option to disable it but smooth scrolling has been debated to death and they ultimately decided to enable it by default. I hope this doesn't turn into yet another smooth scrolling debate...
,
Jun 15 2017
I agree with comment #17. This is slower and slightly nauseating from motion sickness on extended rapid scrolls.
,
Jul 7 2017
Chrome for iPhone already does this, so if it was approved for the iPhone it should be approved for Android phones too.
,
Aug 31 2017
,
Apr 10 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/c79fc93a7ba4a50b5a9add7b2044b6e7f42f206f commit c79fc93a7ba4a50b5a9add7b2044b6e7f42f206f Author: Sandra Sun <sunyunjia@chromium.org> Date: Tue Apr 10 15:22:23 2018 "Find" scrolling should be smoothly animated on Android. This patch enables smooth scroll for "Find" on Android. This is implemented by setting a "smooth_scroll_for_find_enabled" in WebPreferences so that it can be disabled by tests. Currently, smooth scroll is only enabled for ProgrammaticScrolls. However, "Find" is a UserScroll that doesn't scroll "overflow: hidden" scrollers. This patch also makes sure those scrollers won't be affected by the smooth scroll. Bug: 702966 Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Change-Id: I65b5e20b2dad36bc1e6532d20162a643471d43c0 Reviewed-on: https://chromium-review.googlesource.com/978364 Reviewed-by: Philip Jägenstedt <foolip@chromium.org> Reviewed-by: Ken Buchanan <kenrb@chromium.org> Reviewed-by: Avi Drissman <avi@chromium.org> Reviewed-by: David Bokan <bokan@chromium.org> Commit-Queue: Sandra Sun <sunyunjia@chromium.org> Cr-Commit-Position: refs/heads/master@{#549536} [modify] https://crrev.com/c79fc93a7ba4a50b5a9add7b2044b6e7f42f206f/content/browser/find_request_manager_browsertest.cc [modify] https://crrev.com/c79fc93a7ba4a50b5a9add7b2044b6e7f42f206f/content/public/common/common_param_traits_macros.h [modify] https://crrev.com/c79fc93a7ba4a50b5a9add7b2044b6e7f42f206f/content/public/common/web_preferences.cc [modify] https://crrev.com/c79fc93a7ba4a50b5a9add7b2044b6e7f42f206f/content/public/common/web_preferences.h [modify] https://crrev.com/c79fc93a7ba4a50b5a9add7b2044b6e7f42f206f/content/renderer/render_view_impl.cc [modify] https://crrev.com/c79fc93a7ba4a50b5a9add7b2044b6e7f42f206f/third_party/blink/public/web/web_settings.h [modify] https://crrev.com/c79fc93a7ba4a50b5a9add7b2044b6e7f42f206f/third_party/blink/renderer/core/editing/finder/text_finder.cc [modify] https://crrev.com/c79fc93a7ba4a50b5a9add7b2044b6e7f42f206f/third_party/blink/renderer/core/exported/web_settings_impl.cc [modify] https://crrev.com/c79fc93a7ba4a50b5a9add7b2044b6e7f42f206f/third_party/blink/renderer/core/exported/web_settings_impl.h [modify] https://crrev.com/c79fc93a7ba4a50b5a9add7b2044b6e7f42f206f/third_party/blink/renderer/core/frame/local_frame_view.cc [modify] https://crrev.com/c79fc93a7ba4a50b5a9add7b2044b6e7f42f206f/third_party/blink/renderer/core/frame/root_frame_viewport.cc [modify] https://crrev.com/c79fc93a7ba4a50b5a9add7b2044b6e7f42f206f/third_party/blink/renderer/core/frame/root_frame_viewport.h [modify] https://crrev.com/c79fc93a7ba4a50b5a9add7b2044b6e7f42f206f/third_party/blink/renderer/core/frame/settings.json5 [modify] https://crrev.com/c79fc93a7ba4a50b5a9add7b2044b6e7f42f206f/third_party/blink/renderer/core/paint/paint_layer_scrollable_area.cc [modify] https://crrev.com/c79fc93a7ba4a50b5a9add7b2044b6e7f42f206f/third_party/blink/renderer/platform/scroll/scrollable_area.h
,
Apr 12 2018
,
May 25 2018
I'm not seeing this on canary 68.0.3440.0
,
May 25 2018
The feature was implemented but I just disabled the flag yesterday due to some regression. We'll reland it once the regression is fixed before M69.
,
May 26 2018
Thanks. And is this Android only, or all platforms?
,
Jul 30
Is this in 70 Canary?
,
Jul 30
This will be Android only and no, it hasn't yet been reenabled. See issue 845500
,
Jul 30
,
Dec 18
,
Dec 19
I'm on Canary 73.0.3645.0 and it's not working consistently. Go to theverge.com, tap "Find in page" and type in 'comment' , then start tapping the down arrow. More than half the time I tap the down arrow, as it's going down the page, the transition isn't animated/smooth
,
Dec 19
One more request to perfect this: when you're at the final result (it'll show 12/12, for example), if you tap the down arrow once more, it brings you all the way back up to the top of the page but it's way too slow. Is it possible to use the same super fast animated scroll as when you click the "Home" or "End" key on a traditional computer with physical keyboard? (same for when you tap the up arrow if you're on 1/12, it scrolls all the way down the page very slowly)
,
Jan 3
,
Jan 3
|
||||||||||||||||||||
►
Sign in to add a comment |
||||||||||||||||||||
Comment 1 by billdill...@gmail.com
, Mar 19 2017