New issue
Advanced search Search tips

Issue 702951 link

Starred by 2 users

Issue metadata

Status: Verified
Owner:
Closed: Mar 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug

Blocking:
issue 621719



Sign in to add a comment

ChromeOS OOBE: Checkbox label spacing and alignment.

Project Member Reported by alemate@chromium.org, Mar 19 2017

Issue description

Update EULA checkbox spacing and alignment.
 
Blocking: -700646 621719
Status: Started (was: Assigned)
Project Member

Comment 3 by bugdroid1@chromium.org, Mar 23 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5a72306fa280ea7fcd5fcdf8bf6b1f7db9488861

commit 5a72306fa280ea7fcd5fcdf8bf6b1f7db9488861
Author: alemate <alemate@chromium.org>
Date: Thu Mar 23 01:25:10 2017

ChromeOS OOBE: Update alignment of checkbox label.

BUG= 702951 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2759043002
Cr-Commit-Position: refs/heads/master@{#458969}

[modify] https://crrev.com/5a72306fa280ea7fcd5fcdf8bf6b1f7db9488861/chrome/browser/resources/chromeos/login/oobe_eula.css
[modify] https://crrev.com/5a72306fa280ea7fcd5fcdf8bf6b1f7db9488861/chrome/browser/resources/chromeos/login/oobe_eula.html

Labels: Merge-Request-58
Status: Fixed (was: Started)
Project Member

Comment 5 by sheriffbot@chromium.org, Mar 24 2017

Labels: -Merge-Request-58 Hotlist-Merge-Approved Merge-Approved-58
Your change meets the bar and is auto-approved for M58. Please go ahead and merge the CL to branch 3029 manually. Please contact milestone owner if you have questions.
Owners: amineer@(Android), cmasso@(iOS), bhthompson@(ChromeOS), govind@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Project Member

Comment 6 by bugdroid1@chromium.org, Mar 24 2017

Labels: -merge-approved-58 merge-merged-3029
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6979eb487c47659e5f87900392237a7df5bf7b8a

commit 6979eb487c47659e5f87900392237a7df5bf7b8a
Author: Alexander Alekseev <alemate@chromium.org>
Date: Fri Mar 24 03:47:08 2017

ChromeOS OOBE: Update alignment of checkbox label.

BUG= 702951 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2759043002
Cr-Commit-Position: refs/heads/master@{#458969}
(cherry picked from commit 5a72306fa280ea7fcd5fcdf8bf6b1f7db9488861)

Review-Url: https://codereview.chromium.org/2771013003 .
Cr-Commit-Position: refs/branch-heads/3029@{#401}
Cr-Branched-From: 939b32ee5ba05c396eef3fd992822fcca9a2e262-refs/heads/master@{#454471}

[modify] https://crrev.com/6979eb487c47659e5f87900392237a7df5bf7b8a/chrome/browser/resources/chromeos/login/oobe_eula.css
[modify] https://crrev.com/6979eb487c47659e5f87900392237a7df5bf7b8a/chrome/browser/resources/chromeos/login/oobe_eula.html

Is this bug to fix the wrapping of the Learn more that I see on latest M58? 
IMG_20170324_144405.jpg
3.9 MB View Download
Cc: dhadd...@chromium.org
Yes. It should be fixed now.
Components: UI>Shell>OOBE
Status: Verified (was: Fixed)
10109.0.0, 64.0.3261.0

Sign in to add a comment