New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 702940 link

Starred by 2 users

Issue metadata

Status: Verified
Owner:
Last visit > 30 days ago
Closed: Mar 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Mac
Pri: 2
Type: Bug-Regression



Sign in to add a comment

Cookies tab are always empty

Reported by l446240525@gmail.com, Mar 19 2017

Issue description

UserAgent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_10_4) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/59.0.3045.0 Safari/537.36

Steps to reproduce the problem:
.

What is the expected behavior?

What went wrong?
.

Did this work before? Yes 

Chrome version: 59.0.3045.0  Channel: n/a
OS Version: OS X 10.10.4
Flash Version: Shockwave Flash 25.0 r0
 
屏幕快照 2017-03-19 上午10.34.57.png
213 KB View Download
Labels: Needs-Triage-M59

Comment 2 by ja...@apphaus.co.uk, Mar 20 2017

I can replicate in 59.0.3046.0 (Official Build) canary (64-bit) but not 57.0.2987.110 (Official Build) (64-bit).

Possibly introduced in https://codereview.chromium.org/2714913002?

Comment 3 by ja...@apphaus.co.uk, Mar 20 2017

It looks like the issue is that 'Request Cookies' and 'Response Cookies' are treated separately in the Cookies pane in the network panel, and it's not uncommon to see no cookies set in one of these categories. Passing a null cookies parameter to _findSelectedCookie causes a JS error.

I have submitted a CL to codereview: https://codereview.chromium.org/2760013002
Cc: dgozman@chromium.org allada@chromium.org
Labels: ReleaseBlock-Stable M-58
Owner: phulce@chromium.org
Status: Assigned (was: Unconfirmed)
The offending patch was landed in M58.
Project Member

Comment 5 by bugdroid1@chromium.org, Mar 22 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b8fba9d8708e06e1543bc3d9fe589640c8853137

commit b8fba9d8708e06e1543bc3d9fe589640c8853137
Author: james <james@apphaus.co.uk>
Date: Wed Mar 22 19:45:25 2017

DevTools: Fixes regression in cookies tab in Network panel having no output

Clicking on a request in the Network panel and selecting the cookies tab resulted in no output in this tab, despite there being cookies set.

This appears to be a regression in https://codereview.chromium.org/2714913002

BUG= 702940 

Review-Url: https://codereview.chromium.org/2760013002
Cr-Commit-Position: refs/heads/master@{#458847}

[modify] https://crrev.com/b8fba9d8708e06e1543bc3d9fe589640c8853137/third_party/WebKit/Source/devtools/front_end/cookie_table/CookiesTable.js

Comment 6 Deleted

Comment 7 by phulce@chromium.org, Mar 23 2017

Confirmed fix is working as expected in Canary 59.0.3049.
Project Member

Comment 8 by sheriffbot@chromium.org, Mar 23 2017

Labels: -Merge-Request-58 Hotlist-Merge-Approved Merge-Approved-58
Your change meets the bar and is auto-approved for M58. Please go ahead and merge the CL to branch 3029 manually. Please contact milestone owner if you have questions.
Owners: amineer@(Android), cmasso@(iOS), bhthompson@(ChromeOS), govind@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Project Member

Comment 9 by bugdroid1@chromium.org, Mar 24 2017

Labels: -merge-approved-58 merge-merged-3029
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4ef1eee5f993e196c8ad92346ea9ba7e1854e722

commit 4ef1eee5f993e196c8ad92346ea9ba7e1854e722
Author: phulce <phulce@chromium.org>
Date: Fri Mar 24 00:34:29 2017

DevTools: Fixes regression in cookies tab in Network panel having no output

Clicking on a request in the Network panel and selecting the cookies tab resulted in no output in this tab, despite there being cookies set.

This appears to be a regression in https://codereview.chromium.org/2714913002

BUG= 702940 
NOTRY=true
NOPRESUBMIT=true

Review-Url: https://codereview.chromium.org/2760013002
Cr-Commit-Position: refs/heads/master@{#458847}
(cherry picked from commit b8fba9d8708e06e1543bc3d9fe589640c8853137)

Review-Url: https://codereview.chromium.org/2768383003
Cr-Commit-Position: refs/branch-heads/3029@{#400}
Cr-Branched-From: 939b32ee5ba05c396eef3fd992822fcca9a2e262-refs/heads/master@{#454471}

[modify] https://crrev.com/4ef1eee5f993e196c8ad92346ea9ba7e1854e722/third_party/WebKit/Source/devtools/front_end/cookie_table/CookiesTable.js

Cc: rbasuvula@chromium.org
Labels: TE-Verified-M58 TE-Verified-58.0.3029.41
Tested the issue on Mac OS 10.12.3 using chrome latest Beta M58-58.0.3029.41 by following steps mentioned in the original comment. Observed that cookies tab is generating as expected. Hence adding TE-Verified label.

Please find the screen shot for reference.

Thank you!
702940.png
284 KB View Download
Status: Verified (was: Assigned)

Sign in to add a comment