New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 702920 link

Starred by 1 user

Issue metadata

Status: Verified
Owner:
Closed: Apr 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux
Pri: 2
Type: Bug-Security



Sign in to add a comment

Use-of-uninitialized-value in SkConic::evalAt

Project Member Reported by ClusterFuzz, Mar 18 2017

Issue description

Project Member

Comment 1 by sheriffbot@chromium.org, Mar 19 2017

Labels: Pri-2

Comment 2 by tsepez@chromium.org, Mar 20 2017

Components: Internals>Skia
Labels: M-59

Comment 3 by tsepez@chromium.org, Mar 20 2017

Owner: f...@opera.com
Status: Assigned (was: Untriaged)
Guessing https://chromium.googlesource.com/chromium/src/+/2ad2a9bf7205ec77843cf27a7964fda92df386b2 based on regression range.

Comment 4 by f...@opera.com, Mar 21 2017

Cc: caryclark@chromium.org fmalita@chromium.org
This looks like SkConic / SkPathMeasure not dealing with "large" numbers. Some large enough number can cause overflow to occur in the length calculation, which in turn yields both Infs and NaNs in different stages. (This triggers asserts before reaching the exact position above, but it seems this would easily follow as a consequence.) I've attached a boiled down TC in the form of a patch against Skia.

The relationship with my CL is that it - in this particular case - would now include the scale transforms in the transform used to compute the non-scaling-stroke (which in turn yields "large value" geometry.)
0001-Test-for-crbug.com-702920.patch
1.3 KB Download
Project Member

Comment 5 by ClusterFuzz, Apr 18 2017

ClusterFuzz has detected this issue as fixed in range 464942:464964.

Detailed report: https://clusterfuzz.com/testcase?key=6749034019815424

Fuzzer: ifratric-browserfuzzer-v3
Job Type: linux_msan_chrome
Platform Id: linux

Crash Type: Use-of-uninitialized-value
Crash Address: 
Crash State:
  SkConic::evalAt
  compute_pos_tan
  SkPathMeasure::getSegment
  
Sanitizer: memory (MSAN)

Recommended Security Severity: Low

Regressed: https://clusterfuzz.com/revisions?job=linux_msan_chrome&range=451926:451942
Fixed: https://clusterfuzz.com/revisions?job=linux_msan_chrome&range=464942:464964

Reproducer Testcase: https://clusterfuzz.com/download/AMIfv96jv2EEOWedvfy5qXRnTK7JJMLHpEeMlQH0alZUvBgt72iOsbQ12lWB5Fku7jUuCLKspdXleLkK4mBUsmEFV128n1m59iYCrPFGW-g_wt0xFZ5SCI65Yr8utk745UzI1Nd3HmwNvNDBeMQZEdqNwBNZPI-04Lr588ziEXYdZRQhppxZzWNOH-Unf6Z3GINvHrDWtFcrMNqNAxLvv0_UG84dNoWFHcO0X0TxR4uVpDreujHh0pzghBOt5LboCZ43zgjFdPPpivwZuUlnVpkUne5A1XsCJ1TAa9rb0et5nw60dC6tiFeSM2Iu1GmnqT0mHIZrrv1ajY_BTjCH0FAeo-L_nyHui2fzCK9Pak5VBeputyhnWC0duZuA6s_PU5xywq5Sv0ODUMm0d8BSut_95NVZ5wY9hA?testcase_id=6749034019815424


Additional requirements: Requires Gestures

See https://dev.chromium.org/Home/chromium-security/bugs/reproducing-clusterfuzz-bugs for more information.

If you suspect that the result above is incorrect, try re-doing that job on the test case report page.
Project Member

Comment 6 by ClusterFuzz, Apr 18 2017

Labels: ClusterFuzz-Verified
Status: Verified (was: Assigned)
ClusterFuzz testcase 6749034019815424 is verified as fixed, so closing issue.

If this is incorrect, please add ClusterFuzz-Wrong label and re-open the issue.
Project Member

Comment 7 by sheriffbot@chromium.org, Apr 18 2017

Labels: -Restrict-View-SecurityTeam Restrict-View-SecurityNotify
Project Member

Comment 8 by sheriffbot@chromium.org, Jul 25 2017

Labels: -Restrict-View-SecurityNotify allpublic
This bug has been closed for more than 14 weeks. Removing security view restrictions.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Sign in to add a comment