QuicSession not cleaned up in QuicStreamFactory::all_sessions_ map |
||
Issue descriptionChrome Version: 59.0.3045.0 (Official Build) canary (64-bit) OS: Mac OS X Was in the middle of investigating the other issue. Happen to notice that QuicChromiumClientSession received PUBLIC RESET from the server, got removed from active_sessions_. However, it seems never gets deleted from the all_sessions_ map. Although this shouldn't happen in the code: QuicChromiumClientSession::OnConnectionClosed was called (as we have the NetLogEvent:QUIC_SESSION_CLOSED). The session called factory to process its going away, which removed the session from active_sessions_ map NotifyFactoryOfSessionGoingAway; and post a task to notify the factory to delete it from all_sessions_ map in NotifyFactoryOfSessionClosed. For some reason, the last step is not happening.
,
Mar 19 2017
This might NOT be directly related to this bug, I also grabbed a NetLog with my local build Chrome which has more NetLogs for debugging. Reading logs from ID 21504 to 21510, the QuicStreamFactory::Job is deleted in the callback(QuicStreamFactory::OnJobComplete) run, which should be in QuicChromiumClientSession::OnConnectionClosed. This indicate we have a STATE: that a server will have entry in active_sessions_, active_jobs_, and all_sessions_.
,
Mar 20 2017
I took it back, the session are removed. It's the NetLog not closed properly.
,
Mar 20 2017
*whew* Good sleuthing! Shall we WONTFIX this?
,
Mar 20 2017
,
Mar 21 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/27f1087519767c5ba6e57fae028435f4063f1bbe commit 27f1087519767c5ba6e57fae028435f4063f1bbe Author: zhongyi <zhongyi@chromium.org> Date: Tue Mar 21 02:36:14 2017 Fix the NetLog to add end event for QUIC_SESSION in QuicChromiumClientSession destructor so that QUIC_SESSION will not be marked as active when the session is deleted. BUG= 702909 Review-Url: https://codereview.chromium.org/2761053002 Cr-Commit-Position: refs/heads/master@{#458284} [modify] https://crrev.com/27f1087519767c5ba6e57fae028435f4063f1bbe/net/quic/chromium/quic_chromium_client_session.cc |
||
►
Sign in to add a comment |
||
Comment 1 Deleted