New issue
Advanced search Search tips

Issue 702897 link

Starred by 1 user

Issue metadata

Status: Verified
Owner:
Closed: Mar 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux
Pri: 1
Type: Bug



Sign in to add a comment

ASSERT: is_page_valid

Project Member Reported by ClusterFuzz, Mar 18 2017

Issue description

Comment 1 by kcc@chromium.org, Mar 21 2017

Cc: dsinclair@chromium.org
Components: Internals>Plugins>PDF
Owner: npm@chromium.org
Project Member

Comment 2 by bugdroid1@chromium.org, Mar 22 2017

The following revision refers to this bug:
  https://pdfium.googlesource.com/pdfium/+/29041010864c5d9b454ed3739873b2dcccc42767

commit 29041010864c5d9b454ed3739873b2dcccc42767
Author: Nicolas Pena <npm@chromium.org>
Date: Wed Mar 22 17:58:14 2017

Fix ASSERT in CPDF_Data_Avail

If ParseIndirectObjectAt fails, the replaced object will be null. So we can't
ASSERT the output of ValidatePage. CL introducing the ASSERT:
https://codereview.chromium.org/2483633002/

BUG= chromium:702897 

Change-Id: Ib6e8c0bccaf2c05893f0abef27d431e112064865
Reviewed-on: https://pdfium-review.googlesource.com/3146
Reviewed-by: dsinclair <dsinclair@chromium.org>
Commit-Queue: Nicolás Peña <npm@chromium.org>

[modify] https://crrev.com/29041010864c5d9b454ed3739873b2dcccc42767/core/fpdfapi/parser/cpdf_data_avail.cpp

Project Member

Comment 3 by bugdroid1@chromium.org, Mar 22 2017

The following revision refers to this bug:
  https://pdfium.googlesource.com/pdfium/+/29041010864c5d9b454ed3739873b2dcccc42767

commit 29041010864c5d9b454ed3739873b2dcccc42767
Author: Nicolas Pena <npm@chromium.org>
Date: Wed Mar 22 17:58:14 2017

Fix ASSERT in CPDF_Data_Avail

If ParseIndirectObjectAt fails, the replaced object will be null. So we can't
ASSERT the output of ValidatePage. CL introducing the ASSERT:
https://codereview.chromium.org/2483633002/

BUG= chromium:702897 

Change-Id: Ib6e8c0bccaf2c05893f0abef27d431e112064865
Reviewed-on: https://pdfium-review.googlesource.com/3146
Reviewed-by: dsinclair <dsinclair@chromium.org>
Commit-Queue: Nicolás Peña <npm@chromium.org>

[modify] https://crrev.com/29041010864c5d9b454ed3739873b2dcccc42767/core/fpdfapi/parser/cpdf_data_avail.cpp

Project Member

Comment 4 by bugdroid1@chromium.org, Mar 22 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6bd6316584bd2a17476cb3ff7a84b538ee15b204

commit 6bd6316584bd2a17476cb3ff7a84b538ee15b204
Author: pdfium-deps-roller <pdfium-deps-roller@chromium.org>
Date: Wed Mar 22 20:28:51 2017

Roll src/third_party/pdfium/ 5bcd9a322..290410108 (1 commit)

https://pdfium.googlesource.com/pdfium.git/+log/5bcd9a32232e..29041010864c

$ git log 5bcd9a322..290410108 --date=short --no-merges --format='%ad %ae %s'
2017-03-22 npm Fix ASSERT in CPDF_Data_Avail

Created with:
  roll-dep src/third_party/pdfium
BUG= 702897 

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, see:
http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls

TBR=dsinclair@chromium.org

Review-Url: https://codereview.chromium.org/2764373003
Cr-Commit-Position: refs/heads/master@{#458861}

[modify] https://crrev.com/6bd6316584bd2a17476cb3ff7a84b538ee15b204/DEPS

Project Member

Comment 6 by ClusterFuzz, Mar 23 2017

Labels: ClusterFuzz-Verified
Status: Verified (was: Untriaged)
ClusterFuzz testcase 6372362326114304 is verified as fixed, so closing issue.

If this is incorrect, please add ClusterFuzz-Wrong label and re-open the issue.

Sign in to add a comment