MD Settings: Can't delete Geolocation content setting exception |
||||||
Issue descriptionRepro steps: 1) Navigate to https://www.w3schools.com/html/html5_geolocation.asp. 2) Accept the permission. 3) Navigate to chrome://md-settings/content/location 4) Attempt to delete the exception. See attachment. Expected User is able to revoke the permission that was granted. Actual No UI to remove the permission is shown. Note that the old Options display an 'x' icon. Also this might be a problem with more content settings categories, not just Geo.
,
Mar 20 2017
I spoke with Tommy (whom added the "read-only-list" flag that removes the action menu. He and I agree that removing the whole set of actions was too far. We should trim the available actions rather than removing all the actions. So this is essentially a whoops and should be fixed. There could be a debate about whether an X should be shown if that is the only option in the action menu (i.e. a menu with only a "Remove" option). I'll pass this to bettes@ for that answer.
,
Mar 20 2017
Alan, In some sections the only option presented in the action (dots) menu will be "Remove", should we use an X remove button rather than an action menu with one item in it? Or should we use the action menu (with just "Remove")?
,
Mar 20 2017
Thanks for the update.
,
Mar 20 2017
Hey Dom, I marked this as launch blocking, and I'll make sure this gets fixed before launch. Tommy
,
Mar 20 2017
Oops I guess Dave marked this as launch blocking before me.
,
Mar 21 2017
,
Mar 21 2017
I conferred with Alan. He wants a Trash Can icon. And he shall get a trash can icon.
,
Mar 23 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/23db0471ac32d68bb40a9cb53e14a55a371b7f4e commit 23db0471ac32d68bb40a9cb53e14a55a371b7f4e Author: tommycli <tommycli@chromium.org> Date: Thu Mar 23 20:16:38 2017 MD Settings: Allow deleting read-only content setting exceptions. BUG= 702857 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2769453002 Cr-Commit-Position: refs/heads/master@{#459196} [modify] https://crrev.com/23db0471ac32d68bb40a9cb53e14a55a371b7f4e/chrome/browser/resources/settings/site_settings/site_list.html [modify] https://crrev.com/23db0471ac32d68bb40a9cb53e14a55a371b7f4e/chrome/browser/resources/settings/site_settings/site_list.js [modify] https://crrev.com/23db0471ac32d68bb40a9cb53e14a55a371b7f4e/chrome/test/data/webui/settings/site_list_tests.js
,
Mar 24 2017
|
||||||
►
Sign in to add a comment |
||||||
Comment 1 by dominickn@chromium.org
, Mar 20 2017