code note: see TrayNetwork::RequestToggleWifi()

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b0df1652be8318de622d9888d7f1cdc91d955252

commit b0df1652be8318de622d9888d7f1cdc91d955252
Author: estade <estade@chromium.org>
Date: Wed Mar 22 22:41:10 2017

Update appearance of Wi-Fi toggle notification.

1. Fix layout of label.
2. Use vectorized graphics instead of old fashioned PNGs.
3. Add strikethrough ("off") badge.
4. Rename PopupDetailedView function to make it a verb.

BUG= 702855 
TBR=stevenjb@chromium.org

Review-Url: https://codereview.chromium.org/2761313003
Cr-Commit-Position: refs/heads/master@{#458904}

[modify] https://crrev.com/b0df1652be8318de622d9888d7f1cdc91d955252/ash/common/system/chromeos/audio/tray_audio.cc
[modify] https://crrev.com/b0df1652be8318de622d9888d7f1cdc91d955252/ash/common/system/chromeos/brightness/tray_brightness.cc
[modify] https://crrev.com/b0df1652be8318de622d9888d7f1cdc91d955252/ash/common/system/chromeos/network/network_icon.cc
[modify] https://crrev.com/b0df1652be8318de622d9888d7f1cdc91d955252/ash/common/system/chromeos/network/network_icon.h
[modify] https://crrev.com/b0df1652be8318de622d9888d7f1cdc91d955252/ash/common/system/chromeos/network/tray_network.cc
[modify] https://crrev.com/b0df1652be8318de622d9888d7f1cdc91d955252/ash/common/system/chromeos/tray_caps_lock.cc
[modify] https://crrev.com/b0df1652be8318de622d9888d7f1cdc91d955252/ash/common/system/tray/system_tray_item.cc
[modify] https://crrev.com/b0df1652be8318de622d9888d7f1cdc91d955252/ash/common/system/tray/system_tray_item.h
[modify] https://crrev.com/b0df1652be8318de622d9888d7f1cdc91d955252/ash/common/system/tray_accessibility.cc
[modify] https://crrev.com/b0df1652be8318de622d9888d7f1cdc91d955252/ash/resources/ash_resources.grd
[delete] https://crrev.com/4bb495001519e375c738525f710cf2875d7df25a/ash/resources/default_100_percent/cros/network/status_wifi_disabled.png
[delete] https://crrev.com/4bb495001519e375c738525f710cf2875d7df25a/ash/resources/default_100_percent/cros/network/status_wifi_enabled.png
[delete] https://crrev.com/4bb495001519e375c738525f710cf2875d7df25a/ash/resources/default_200_percent/cros/network/status_wifi_disabled.png
[modify] https://crrev.com/b0df1652be8318de622d9888d7f1cdc91d955252/ash/resources/vector_icons/BUILD.gn
[add] https://crrev.com/b0df1652be8318de622d9888d7f1cdc91d955252/ash/resources/vector_icons/network_badge_off.icon
[modify] https://crrev.com/b0df1652be8318de622d9888d7f1cdc91d955252/chrome/browser/chromeos/system/tray_accessibility_browsertest.cc

Sebastien, can you try this on your device and tell me what you think of the strike-through? I made it myself, if it needs tweaking please provide an SVG (just the strike through is needed, not the wifi pie slice).

ping sgabriel --- see #4

It's very close to the .svg I created for that (see attached) and that is available on the drive (https://drive.google.com/drive/folders/0B6x6iYCtKinEd3BxelVZWGxmekk?usp=sharing)

Why not using this one ?
Also the floating container is 44dp and should be 48dp. Can you correct that as well?


This made me notice a mistake in the system menu where we do not use this icon. see bug 706453

Deleted: signal_wifi_bar_off-1x.svg 1.2 KB

signal_wifi_bar_off-1x.svg 1.2 KB Download

Deleted: signal_wifi_bar_off-2x.svg 1.3 KB

signal_wifi_bar_off-2x.svg 1.3 KB Download

I did not use yours because I didn't know it existed and because I wanted just the strikethrough by itself. (We already draw the pie slice without an icon definition and reusing that gets you an extra nice, sharp point at all scales.) I'll try to extract the strikethrough from yours.

Got it. Your is really close to mine btw. See an overlay attached. it's just a tad too thick.

Deleted: Screen Shot 2017-03-29 at 10.13.10 AM.png 15.2 KB

	Screen Shot 2017-03-29 at 10.13.10 AM.png 15.2 KB View Download

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0e7814d516c002db64d75bad3d519740a266dd54

commit 0e7814d516c002db64d75bad3d519740a266dd54
Author: estade <estade@chromium.org>
Date: Tue Apr 04 18:27:16 2017

cros: manual tweaks to network off badge (strikethrough)

BUG= 702855 

Review-Url: https://codereview.chromium.org/2793903005
Cr-Commit-Position: refs/heads/master@{#461777}

[modify] https://crrev.com/0e7814d516c002db64d75bad3d519740a266dd54/ash/resources/vector_icons/BUILD.gn
[add] https://crrev.com/0e7814d516c002db64d75bad3d519740a266dd54/ash/resources/vector_icons/network_badge_off.1x.icon
[modify] https://crrev.com/0e7814d516c002db64d75bad3d519740a266dd54/ash/resources/vector_icons/network_badge_off.icon