New issue
Advanced search Search tips

Issue 702851 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Mar 2017
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug



Sign in to add a comment

PRESUBMIT check for added DEPS shouldn't warn if DEPS are just being reordered

Project Member Reported by dcheng@chromium.org, Mar 18 2017

Issue description

Because it's a no-op.

 
Project Member

Comment 2 by bugdroid1@chromium.org, Mar 22 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/63dd720c98271a15da8e483906dc92c3d0603e7d

commit 63dd720c98271a15da8e483906dc92c3d0603e7d
Author: dcheng <dcheng@chromium.org>
Date: Wed Mar 22 23:26:11 2017

Don't require DEPS OWNERS when moving lines around in a DEPS file.

As a bonus, less regex than before and also correctly handles the
'!' prefix in DEPS files now.

BUG= 702851 

Review-Url: https://codereview.chromium.org/2759593003
Cr-Commit-Position: refs/heads/master@{#458928}

[modify] https://crrev.com/63dd720c98271a15da8e483906dc92c3d0603e7d/PRESUBMIT.py
[modify] https://crrev.com/63dd720c98271a15da8e483906dc92c3d0603e7d/PRESUBMIT_test.py

Comment 3 by dcheng@chromium.org, Mar 23 2017

Status: Fixed (was: Started)
Project Member

Comment 4 by bugdroid1@chromium.org, Mar 23 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b89c4320456a8a5b52c5b4fb4cee7421081f4616

commit b89c4320456a8a5b52c5b4fb4cee7421081f4616
Author: ksakamoto <ksakamoto@chromium.org>
Date: Thu Mar 23 04:39:10 2017

Revert of Don't require DEPS OWNERS when moving lines around in a DEPS file. (patchset #2 id:20001 of https://codereview.chromium.org/2759593003/ )

Reason for revert:
Broke DEPS auto rollers.
https://bugs.chromium.org/p/chromium/issues/detail?id=704405

Original issue's description:
> Don't require DEPS OWNERS when moving lines around in a DEPS file.
>
> As a bonus, less regex than before and also correctly handles the
> '!' prefix in DEPS files now.
>
> BUG= 702851 
>
> Review-Url: https://codereview.chromium.org/2759593003
> Cr-Commit-Position: refs/heads/master@{#458928}
> Committed: https://chromium.googlesource.com/chromium/src/+/63dd720c98271a15da8e483906dc92c3d0603e7d

TBR=dpranke@chromium.org,dcheng@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG= 702851 

Review-Url: https://codereview.chromium.org/2772693002
Cr-Commit-Position: refs/heads/master@{#459004}

[modify] https://crrev.com/b89c4320456a8a5b52c5b4fb4cee7421081f4616/PRESUBMIT.py
[modify] https://crrev.com/b89c4320456a8a5b52c5b4fb4cee7421081f4616/PRESUBMIT_test.py

Project Member

Comment 5 by bugdroid1@chromium.org, Mar 31 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/da9479f3d2ff217723adc834581d41671c18d06c

commit da9479f3d2ff217723adc834581d41671c18d06c
Author: dcheng <dcheng@chromium.org>
Date: Fri Mar 31 23:09:37 2017

Don't require DEPS OWNERS when moving lines around in a DEPS file.

As a bonus, less regex than before and also correctly handles the
'!' prefix in DEPS files now.

BUG= 702851 
R=dpranke@chromium.org

Review-Url: https://codereview.chromium.org/2768063004
Cr-Commit-Position: refs/heads/master@{#461266}

[modify] https://crrev.com/da9479f3d2ff217723adc834581d41671c18d06c/PRESUBMIT.py
[modify] https://crrev.com/da9479f3d2ff217723adc834581d41671c18d06c/PRESUBMIT_test.py

Project Member

Comment 6 by bugdroid1@chromium.org, Apr 3 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/be5ca3ea5d86ccc88ff78f5f0ff7cd5c8e796196

commit be5ca3ea5d86ccc88ff78f5f0ff7cd5c8e796196
Author: sammc <sammc@chromium.org>
Date: Mon Apr 03 01:48:36 2017

Revert of Don't require DEPS OWNERS when moving lines around in a DEPS file. (patchset #3 id:40001 of https://codereview.chromium.org/2768063004/ )

Reason for revert:
Breaks presubmit when adding DEPS files: https://luci-logdog.appspot.com/v/?s=chromium%2Fbb%2Ftryserver.chromium.linux%2Fchromium_presubmit%2F400708%2F%2B%2Frecipes%2Fsteps%2Fpresubmit%2F0%2Fstdout

Original issue's description:
> Don't require DEPS OWNERS when moving lines around in a DEPS file.
>
> As a bonus, less regex than before and also correctly handles the
> '!' prefix in DEPS files now.
>
> BUG= 702851 
> R=dpranke@chromium.org
>
> Review-Url: https://codereview.chromium.org/2768063004
> Cr-Commit-Position: refs/heads/master@{#461266}
> Committed: https://chromium.googlesource.com/chromium/src/+/da9479f3d2ff217723adc834581d41671c18d06c

TBR=dpranke@chromium.org,dcheng@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG= 702851 

Review-Url: https://codereview.chromium.org/2792853002
Cr-Commit-Position: refs/heads/master@{#461358}

[modify] https://crrev.com/be5ca3ea5d86ccc88ff78f5f0ff7cd5c8e796196/PRESUBMIT.py
[modify] https://crrev.com/be5ca3ea5d86ccc88ff78f5f0ff7cd5c8e796196/PRESUBMIT_test.py

Project Member

Comment 7 by bugdroid1@chromium.org, Apr 14 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4dcdb6bbf30724ed511754410da319c35c3546ca

commit 4dcdb6bbf30724ed511754410da319c35c3546ca
Author: Daniel Cheng <dcheng@chromium.org>
Date: Fri Apr 14 01:29:30 2017

Don't require DEPS OWNERS when moving lines around in a DEPS file.

As a bonus, less regex than before and also correctly handles the
'!' prefix in DEPS files now.

Bug:  702851 
Change-Id: Ic086cf0984bd96ba429dfdcac7dcce53616eab2d
Reviewed-on: https://chromium-review.googlesource.com/476026
Commit-Queue: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Cr-Commit-Position: refs/heads/master@{#464648}
[modify] https://crrev.com/4dcdb6bbf30724ed511754410da319c35c3546ca/PRESUBMIT.py
[modify] https://crrev.com/4dcdb6bbf30724ed511754410da319c35c3546ca/PRESUBMIT_test.py

 Issue 700108  has been merged into this issue.

Sign in to add a comment