New issue
Advanced search Search tips

Issue 702841 link

Starred by 1 user

Issue metadata

Status: Archived
Owner:
Closed: Mar 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 3
Type: Bug



Sign in to add a comment

CrOS: deprecate use of base::MessageLoop::Run / RunUntilIdle

Project Member Reported by benchan@chromium.org, Mar 18 2017

Issue description

base::MessageLoop::Run / RunUntilIdle has been deprecated ( issue 616447 ) and removed from chrome/base (crrev.com/2356383003). We should update CrOS code to remove usage of these methods before the next libchrome uprev.
 
Status: Started (was: Assigned)
Project Member

Comment 2 by bugdroid1@chromium.org, Mar 18 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform2/+/d5118da6f624deb7145a576d15d72d5c9e45c5b1

commit d5118da6f624deb7145a576d15d72d5c9e45c5b1
Author: Ben Chan <benchan@chromium.org>
Date: Sat Mar 18 21:24:51 2017

power: use base::RunLoop::Run() instead of base::MessageLoop::Run()

base::MessageLoop::Run() has been deprecated and will be removed from
libchrome. This CL updates powerd, powerd_dbus_suspend, and
suspend_delay_sample to use base::RunLoop::Run() instead.

BUG= chromium:702841 
TEST=Run unit tests.
TEST=Manually run powerd, powerd_dbus_suspend, and suspend_delay_sample.

Change-Id: I873bdc875b5800f05ce887006cec3872d99ddb1c
Reviewed-on: https://chromium-review.googlesource.com/457159
Commit-Ready: Ben Chan <benchan@chromium.org>
Tested-by: Ben Chan <benchan@chromium.org>
Reviewed-by: Dan Erat <derat@chromium.org>

[modify] https://crrev.com/d5118da6f624deb7145a576d15d72d5c9e45c5b1/power_manager/tools/powerd_dbus_suspend.cc
[modify] https://crrev.com/d5118da6f624deb7145a576d15d72d5c9e45c5b1/power_manager/tools/suspend_delay_sample.cc
[modify] https://crrev.com/d5118da6f624deb7145a576d15d72d5c9e45c5b1/power_manager/powerd/main.cc

Project Member

Comment 3 by bugdroid1@chromium.org, Mar 21 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform2/+/1dc00f1a510222c66eda861256b2db1aa6f255a6

commit 1dc00f1a510222c66eda861256b2db1aa6f255a6
Author: Ben Chan <benchan@chromium.org>
Date: Tue Mar 21 02:30:13 2017

biod: use base::RunLoop::Run() instead of base::MessageLoop::Run()

base::MessageLoop::Run() has been deprecated and will be removed from
libchrome. This CL updates biod to use base::RunLoop::Run() instead, and
also instantiates base::AtExitManager at an earlier stage to ensure it's
available for other classes to use it.

BUG= chromium:702841 
TEST=Run unit tests and manually verify biod starts.

Change-Id: I08a7bf6d028b54b60244dabb6eaae1f73fcec1c8
Reviewed-on: https://chromium-review.googlesource.com/457123
Commit-Ready: Ben Chan <benchan@chromium.org>
Tested-by: Ben Chan <benchan@chromium.org>
Reviewed-by: Zach Reizner <zachr@chromium.org>

[modify] https://crrev.com/1dc00f1a510222c66eda861256b2db1aa6f255a6/biod/main.cc

Project Member

Comment 4 by bugdroid1@chromium.org, Mar 21 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform2/+/8d70b399f78bd546da164ecf87bac1423f08b6c1

commit 8d70b399f78bd546da164ecf87bac1423f08b6c1
Author: Ben Chan <benchan@chromium.org>
Date: Tue Mar 21 02:30:12 2017

container_utils: use base::RunLoop::Run() instead of base::MessageLoop::Run()

base::MessageLoop::Run() has been deprecated and will be removed from
libchrome. This CL updates device_jail_utility to use
base::RunLoop::Run() instead.

BUG= chromium:702841 
TEST=Run unit tests and manually verify device_jail_utility starts.

Change-Id: I6eda07e8aa29ee145eafcf332f6cf572eb5fdb75
Reviewed-on: https://chromium-review.googlesource.com/457124
Commit-Ready: Ben Chan <benchan@chromium.org>
Tested-by: Ben Chan <benchan@chromium.org>
Reviewed-by: Eric Caruso <ejcaruso@chromium.org>
Reviewed-by: Mike Frysinger <vapier@chromium.org>

[modify] https://crrev.com/8d70b399f78bd546da164ecf87bac1423f08b6c1/container_utils/device_jail/device_jail_utility.cc

Status: Fixed (was: Started)

Comment 6 by dchan@google.com, May 30 2017

Labels: VerifyIn-60

Comment 7 by dchan@chromium.org, Aug 1 2017

Labels: VerifyIn-61

Comment 8 by dchan@chromium.org, Jan 22 2018

Status: Archived (was: Fixed)

Sign in to add a comment