Add stacktrace to know when a frame is attached to a page. |
|||
Issue descriptionIt would be nice to know the origin of a frame is. This could be accomplished if a stacktrace of when the creation of the frame is known. Right now it's hard to predict because a third party may add an about:blank iframe and then another ad network may come in and inject javascript into the iframe making it difficult to know which ad network might own the original frame.
,
Mar 22 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/ddb562bb7707d2d91253156c0c7efc04cffce6f5 commit ddb562bb7707d2d91253156c0c7efc04cffce6f5 Author: allada <allada@chromium.org> Date: Wed Mar 22 18:36:58 2017 [Devtools] Add stacktrace for Page.frameAttached event This patch adds possible stacktrace for when a frame is attached to a page for devtools. This will later be useful to know who/what created an iframe on a page. R=dgozman,caseq BUG= 702820 Review-Url: https://codereview.chromium.org/2749383005 Cr-Commit-Position: refs/heads/master@{#458815} [add] https://crrev.com/ddb562bb7707d2d91253156c0c7efc04cffce6f5/third_party/WebKit/LayoutTests/inspector-protocol/page/frameAttachedStacktrace-expected.txt [add] https://crrev.com/ddb562bb7707d2d91253156c0c7efc04cffce6f5/third_party/WebKit/LayoutTests/inspector-protocol/page/frameAttachedStacktrace.html [modify] https://crrev.com/ddb562bb7707d2d91253156c0c7efc04cffce6f5/third_party/WebKit/Source/core/inspector/InspectorPageAgent.cpp [modify] https://crrev.com/ddb562bb7707d2d91253156c0c7efc04cffce6f5/third_party/WebKit/Source/core/inspector/browser_protocol.json [modify] https://crrev.com/ddb562bb7707d2d91253156c0c7efc04cffce6f5/third_party/WebKit/Source/devtools/front_end/sdk/ResourceTreeModel.js
,
Apr 17 2017
,
May 10 2017
,
May 10 2017
Blaise, does this need more frontend work? If not, what's the workflow as an end-user for accessing this stack trace info?
,
May 10 2017
#5: Yes there is more front-end work needed. We exposed it only for product registry to lookup frame creation info for now. |
|||
►
Sign in to add a comment |
|||
Comment 1 by pfeldman@chromium.org
, Mar 21 2017