Make SPV2 trybot run with dchecks enabled |
||
Issue descriptionThe SPV2 trybot (http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_layout_tests_slimming_paint_v2) currently runs without DCHECKs because too many tests hit dchecks. This is quickly becoming not true though--only 482 tests current hit DCHECKS and most of these are related to SVGImage and SVG filters. Once Chris's work on SVGImage is complete, we should turn on DCHECKs on the SPV2 trybot.
,
Apr 4 2017
Thanks to Chris and Tien-Ren this should be possible now.
,
Apr 10 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/1e503ec28387c6ed0e5da7e17560a6e7ddb1a65a commit 1e503ec28387c6ed0e5da7e17560a6e7ddb1a65a Author: pdr <pdr@chromium.org> Date: Mon Apr 10 23:47:26 2017 Mark 201 DCHECK SPV2 tests as failing/crashing This patch prepares SPV2 expectations for enabling DCHECKs. BUG= 702805 Review-Url: https://codereview.chromium.org/2811593005 Cr-Commit-Position: refs/heads/master@{#463449} [modify] https://crrev.com/1e503ec28387c6ed0e5da7e17560a6e7ddb1a65a/third_party/WebKit/LayoutTests/FlagExpectations/enable-slimming-paint-v2
,
Apr 12 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/d850820a384d5cad1cbbcdfc209becdaf6beae88 commit d850820a384d5cad1cbbcdfc209becdaf6beae88 Author: pdr <pdr@chromium.org> Date: Wed Apr 12 17:41:27 2017 Make linux_layout_tests_slimming_paint_v2 run with dcheck_always_on This patch updates the slimming paint v2 trybot to run with dcheck_always_on. BUG= 702805 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Review-Url: https://codereview.chromium.org/2816613002 Cr-Commit-Position: refs/heads/master@{#464071} [modify] https://crrev.com/d850820a384d5cad1cbbcdfc209becdaf6beae88/third_party/WebKit/LayoutTests/FlagExpectations/enable-slimming-paint-v2 [modify] https://crrev.com/d850820a384d5cad1cbbcdfc209becdaf6beae88/tools/mb/mb_config.pyl
,
Apr 12 2017
One note: these tests now run with release+dchecks which is slightly different than debug. |
||
►
Sign in to add a comment |
||
Comment 1 by schenney@chromium.org
, Mar 20 2017