New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 702801 link

Starred by 2 users

Issue metadata

Status: WontFix
Owner: ----
Closed: Aug 2017
Cc:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Feature



Sign in to add a comment

Feature request: marking status of CL

Project Member Reported by rlanday@chromium.org, Mar 17 2017

Issue description

I've noticed a couple of workflow issues working with the code review tool and would like to request some new features:

- Sometimes a reviewer will request changes that require a certain amount of back-and-forth, comments, etc. to address and it's not always clear when the CL is ready for review again. In my opinion, the reviewer should be able to mark a CL as "changes required", and it would remain in that state until either the CL is re-uploaded or the author re-requests review.

- Sometimes I'll upload a CL but realize I need to make changes. I should be able to mark a CL as "changes planned" to avoid wasting reviewers' time reviewing something I'm about to change.

- Sometimes a non-owner will LGTM a CL, and the tool will show it as green as if it's ready to be landed, and then either I'll forget I need an owner LGTM and waste time trying to land it and having the commit queue reject it, or the owner will start ignoring the CL because they think it's already been reviewed. Ideally the code review tool would be aware of the OWNERS lists and not show the CL as green in the list if more LGTMs are required. At the very least, the CL should not be green if I've marked a reviewer as required and that reviewer has not provided an LGTM.
 
Cc: -andyb...@chromium.org logan@google.com wyatta@google.com
Status: Available (was: Untriaged)
This is great feedback. Thank you for taking the time to file. Since we will be moving to Gerrit soon, I’m ccing the appropriate team members so that they can take this into account.
Status: WontFix (was: Available)
Rietveld is deprecated in favor of Gerrit.

Sign in to add a comment