New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 702789 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: May 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: iOS
Pri: 3
Type: Feature



Sign in to add a comment

[Cronet] Allow setting 'Experimental Options' on iOS

Project Member Reported by mef@chromium.org, Mar 17 2017

Issue description

ExperimentalCronetEngine.Builder on Android provides a method to set JSON-formatted experimental options.

We need to add corresponding method to Cronet object on iOS.
 
Project Member

Comment 2 by bugdroid1@chromium.org, Apr 5 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5e10e328115fa52a2fd8a749642d4598b8b7cb9d

commit 5e10e328115fa52a2fd8a749642d4598b8b7cb9d
Author: lilyhoughton <lilyhoughton@chromium.org>
Date: Wed Apr 05 14:40:33 2017

Revert of [cronet] Expose API to set experimental options (patchset #3 id:40001 of https://codereview.chromium.org/2760073002/ )

Reason for revert:
seems to break ios-simulator trybot

Original issue's description:
> [cronet] Expose API to set experimental options
>
> Add CPP function CronetEnvironment::set_experimental_options(std::string)
> and Obj-C function [Cronet setExperimentalOption:(NSString*)].
>
> BUG= 702789 
> CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_cronet_tester
>
> Review-Url: https://codereview.chromium.org/2760073002
> Cr-Commit-Position: refs/heads/master@{#461511}
> Committed: https://chromium.googlesource.com/chromium/src/+/afb25842158a4bad4c7e61dfc0b1c48223f9d351

TBR=mef@chromium.org,xunjieli@chromium.org,lilyhoughton@google.com
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG= 702789 

Review-Url: https://codereview.chromium.org/2803443002
Cr-Commit-Position: refs/heads/master@{#462066}

[modify] https://crrev.com/5e10e328115fa52a2fd8a749642d4598b8b7cb9d/components/cronet/ios/Cronet.h
[modify] https://crrev.com/5e10e328115fa52a2fd8a749642d4598b8b7cb9d/components/cronet/ios/Cronet.mm
[modify] https://crrev.com/5e10e328115fa52a2fd8a749642d4598b8b7cb9d/components/cronet/ios/cronet_environment.h
[modify] https://crrev.com/5e10e328115fa52a2fd8a749642d4598b8b7cb9d/components/cronet/ios/cronet_environment.mm
[modify] https://crrev.com/5e10e328115fa52a2fd8a749642d4598b8b7cb9d/components/cronet/ios/test/cronet_http_test.mm
[modify] https://crrev.com/5e10e328115fa52a2fd8a749642d4598b8b7cb9d/components/cronet/ios/test/start_cronet.mm

Project Member

Comment 3 by bugdroid1@chromium.org, Apr 26 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3c82bec19b9876265cc17d515f8c49f638dbaf00

commit 3c82bec19b9876265cc17d515f8c49f638dbaf00
Author: lilyhoughton <lilyhoughton@google.com>
Date: Wed Apr 26 18:53:15 2017

[cronet] Expose API to set experimental options

Add CPP function CronetEnvironment::set_experimental_options(std::string)
and Obj-C function [Cronet setExperimentalOption:(NSString*)].

BUG= 702789 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_cronet_tester

Review-Url: https://codereview.chromium.org/2760073002
Cr-Original-Commit-Position: refs/heads/master@{#461511}
Committed: https://chromium.googlesource.com/chromium/src/+/afb25842158a4bad4c7e61dfc0b1c48223f9d351
Review-Url: https://codereview.chromium.org/2760073002
Cr-Commit-Position: refs/heads/master@{#467399}

[modify] https://crrev.com/3c82bec19b9876265cc17d515f8c49f638dbaf00/components/cronet/ios/Cronet.h
[modify] https://crrev.com/3c82bec19b9876265cc17d515f8c49f638dbaf00/components/cronet/ios/Cronet.mm
[modify] https://crrev.com/3c82bec19b9876265cc17d515f8c49f638dbaf00/components/cronet/ios/cronet_environment.h
[modify] https://crrev.com/3c82bec19b9876265cc17d515f8c49f638dbaf00/components/cronet/ios/cronet_environment.mm
[modify] https://crrev.com/3c82bec19b9876265cc17d515f8c49f638dbaf00/components/cronet/ios/test/cronet_http_test.mm
[modify] https://crrev.com/3c82bec19b9876265cc17d515f8c49f638dbaf00/components/cronet/ios/test/start_cronet.mm

Status: Fixed (was: Assigned)

Sign in to add a comment