threat_dom_details.cc size_t to int conversion errors on win x64 |
|||||
Issue descriptionFAILED: obj/components/safe_browsing/renderer/renderer/threat_dom_details.obj ninja -t msvc -e environment.x64 -- E:\b\c\goma_client/gomacc.exe "E:\b\depot_tools\win_toolchain\vs_files\d3cb0e37bdd120ad0ac4650b674b09e81be45616\VC\bin\amd64/cl.exe" /nologo /showIncludes /FC @obj/components/safe_browsing/renderer/renderer/threat_dom_details.obj.rsp /c ../../components/safe_browsing/renderer/threat_dom_details.cc /Foobj/components/safe_browsing/renderer/renderer/threat_dom_details.obj /Fd"obj/components/safe_browsing/renderer/renderer_cc.pdb" e:\b\c\b\win\src\components\safe_browsing\renderer\threat_dom_details.cc(174): error C2220: warning treated as error - no 'object' file generated e:\b\c\b\win\src\components\safe_browsing\renderer\threat_dom_details.cc(174): warning C4267: 'initializing': conversion from 'size_t' to 'int', possible loss of data e:\b\c\b\win\src\components\safe_browsing\renderer\threat_dom_details.cc(174): warning C4267: 'initializing': conversion from 'size_t' to 'const int', possible loss of data e:\b\c\b\win\src\components\safe_browsing\renderer\threat_dom_details.cc(199): warning C4267: '=': conversion from 'size_t' to 'int', possible loss of data [28449/43172] CXX obj/content/renderer/renderer/pepper_webplugin_impl.obj
,
Mar 20 2017
,
Mar 20 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/812a97d083eef76745dc7469f9cc4ca4f2ed2881 commit 812a97d083eef76745dc7469f9cc4ca4f2ed2881 Author: lpz <lpz@chromium.org> Date: Mon Mar 20 20:06:17 2017 Change some ints to size_t to fix warning on win64 builds BUG= 702773 Review-Url: https://codereview.chromium.org/2760803003 Cr-Commit-Position: refs/heads/master@{#458156} [modify] https://crrev.com/812a97d083eef76745dc7469f9cc4ca4f2ed2881/chrome/renderer/safe_browsing/threat_dom_details.cc
,
Mar 21 2017
,
Mar 21 2017
hmm looks like still errors: FAILED: obj/components/safe_browsing/renderer/renderer/threat_dom_details.obj ninja -t msvc -e environment.x64 -- E:\b\c\goma_client/gomacc.exe "E:\b\depot_tools\win_toolchain\vs_files\d3cb0e37bdd120ad0ac4650b674b09e81be45616\VC\bin\amd64/cl.exe" /nologo /showIncludes /FC @obj/components/safe_browsing/renderer/renderer/threat_dom_details.obj.rsp /c ../../components/safe_browsing/renderer/threat_dom_details.cc /Foobj/components/safe_browsing/renderer/renderer/threat_dom_details.obj /Fd"obj/components/safe_browsing/renderer/renderer_cc.pdb" e:\b\c\b\win\src\components\safe_browsing\renderer\threat_dom_details.cc(112): error C2220: warning treated as error - no 'object' file generated e:\b\c\b\win\src\components\safe_browsing\renderer\threat_dom_details.cc(112): warning C4267: 'initializing': conversion from 'size_t' to 'int', possible loss of data e:\b\c\b\win\src\components\safe_browsing\renderer\threat_dom_details.cc(175): warning C4267: '=': conversion from 'size_t' to 'int', possible loss of data e:\b\c\b\win\src\components\safe_browsing\renderer\threat_dom_details.cc(183): warning C4267: 'argument': conversion from 'size_t' to 'const int', possible loss of data
,
Mar 21 2017
FYI patch I am trying to land: https://codereview.chromium.org/2764883002/
,
Mar 21 2017
Ahh, thanks for the CL, will help to reproduce this.
,
Mar 24 2017
Tim: would you mind taking a quick look at https://codereview.chromium.org/2770493004/# I think it should resolve this. Thanks.
,
Mar 24 2017
yes thanks, just lgtm'ed it )
,
Mar 24 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/ac4f2ee6eef06c8c345eed0a01bf64ab3df642eb commit ac4f2ee6eef06c8c345eed0a01bf64ab3df642eb Author: lpz <lpz@chromium.org> Date: Fri Mar 24 15:09:00 2017 Remove disable warnings compile flag in safebrowsing component, and fix some type win64 type errors that were found. BUG= 700351 , 702773 Review-Url: https://codereview.chromium.org/2770493004 Cr-Commit-Position: refs/heads/master@{#459425} [modify] https://crrev.com/ac4f2ee6eef06c8c345eed0a01bf64ab3df642eb/components/safe_browsing/renderer/BUILD.gn [modify] https://crrev.com/ac4f2ee6eef06c8c345eed0a01bf64ab3df642eb/components/safe_browsing/renderer/threat_dom_details.cc
,
Mar 24 2017
|
|||||
►
Sign in to add a comment |
|||||
Comment 1 by nparker@chromium.org
, Mar 17 2017