chromeosInfoPrivate: expose "device type" signal |
||||||||
Issue descriptionSimilarly to how the managed device ( crbug.com/682837 ) and playstore ( crbug.com/644432 ) signals were added recently for use by the Get Help app, also add a new parameter to chromeosInfoPrivate for device type ("chromebook", "chromebit", "chromebox", etc). (note: it will be renamed to chromeosInfo and will be available to all kiosk apps with crbug.com/629931)
,
Mar 17 2017
Do you happen to have a full list of device type? We currently don't have a device classification like 'chromebook', 'chromebit'... We only have some available attributes to help determine which device type it is. We may need to create a new classification for this, so a full list will be needed.
,
Mar 17 2017
,
Mar 17 2017
,
Mar 17 2017
@morsed: Sorry, @rkc pointed me to the place where we have the device type info. It has five values: Chromebox / Chromebase / Chromebit / Chromebook / Unknown. I'll use that directly.
,
Mar 17 2017
,
Mar 17 2017
,
Mar 22 2017
,
Mar 23 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/209f4397c58d883b3d8bbbdacf53425c07f434e5 commit 209f4397c58d883b3d8bbbdacf53425c07f434e5 Author: wzang <wzang@chromium.org> Date: Thu Mar 23 01:51:41 2017 ChromeOS: Expose 'device type' signal For use by the Get Help app, similar to how the 'playstore status' and 'managed device' were added recently. If the device type is 'unknown', return 'chromedevice' instead, otherwise return the device type unchanged. BUG= 702772 Review-Url: https://codereview.chromium.org/2761263007 Cr-Commit-Position: refs/heads/master@{#458973} [modify] https://crrev.com/209f4397c58d883b3d8bbbdacf53425c07f434e5/chrome/browser/chromeos/extensions/info_private_api.cc [modify] https://crrev.com/209f4397c58d883b3d8bbbdacf53425c07f434e5/chrome/browser/chromeos/extensions/info_private_apitest.cc [modify] https://crrev.com/209f4397c58d883b3d8bbbdacf53425c07f434e5/chrome/common/extensions/api/chromeos_info_private.json [modify] https://crrev.com/209f4397c58d883b3d8bbbdacf53425c07f434e5/chrome/test/data/extensions/api_test/chromeos_info_private/extended/background.js
,
Mar 23 2017
,
Apr 5 2017
|
||||||||
►
Sign in to add a comment |
||||||||
Comment 1 Deleted