New issue
Advanced search Search tips

Issue 702761 link

Starred by 1 user
Status: Fixed
Owner: ----
Closed: Sep 2017
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug



Sign in to add a comment

[WPT import] wpt-importer job is red when import succeeded

Project Member Reported by qyears...@chromium.org, Mar 17 2017 
Currently what happens when import succeeds is this:

  File ".../webkitpy/w3c/test_importer.py", line 368, in do_auto_update
    self.git_cl.run(['set-close'])
webkitpy.common.system.executive.ScriptError: Failed to run "['git', 'cl', 'set-close']" exit_code: 1

output: Last 500 characters of output:
._GetGerritHost(), self.GetIssue(), msg='')
  File "/mnt/data/b/depot_tools/gerrit_util.py", line 569, in AbandonChange
    return ReadHttpJsonResponse(conn, ignore_404=False)
  File "/mnt/data/b/depot_tools/gerrit_util.py", line 377, in ReadHttpJsonResponse
    conn, expect_status=expect_status, ignore_404=ignore_404)
  File "/mnt/data/b/depot_tools/gerrit_util.py", line 370, in ReadHttpResponse
    raise GerritError(response.status, reason)
gerrit_util.GerritError: Conflict: change is merged

In this case, the import script should check whether the change is merged, and if so, exit with status 0.
Project Member

Comment 1 by bugdroid1@chromium.org, Apr 19 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7865cc51cb1ebe2c072f62f7de98723e0f326c59

commit 7865cc51cb1ebe2c072f62f7de98723e0f326c59
Author: qyearsley <qyearsley@chromium.org>
Date: Wed Apr 19 00:41:57 2017

wpt-importer: Don't run git cl set-close when there are no try job results.

Originally in the do_auto_update method of the importer, I added
a section:

	if not try_results:
		_log.error('No try job results.')
		self.git_cl.run(['set-close']) return False

The purpose of this was to abort and indicate failure if something went
completely wrong with the CQ; I was expecting that try_results should
contain CQ bot try results like:

	{
		'builder_name': 'linux_chromium_rel_ng', 'status':
		'COMPLETED', 'result': 'SUCCESS',
	}, ...

But apparently this isn't the case, although I'm not sure why.
This CL replaces that section with just logging the try_results list
and continuing, which I believe should work as intened anyway and
will help us understand what try_results actually contains.

BUG= 702761 

Review-Url: https://codereview.chromium.org/2827823002
Cr-Commit-Position: refs/heads/master@{#465445}

[modify] https://crrev.com/7865cc51cb1ebe2c072f62f7de98723e0f326c59/third_party/WebKit/Tools/Scripts/webkitpy/w3c/test_importer.py

Comment 2 by qyears...@chromium.org, Apr 19 2017

Status: Fixed (was: Available)
Expecting this to be fixed now, will be able to tell on the next successful wpt import.

Comment 3 by qyears...@chromium.org, May 21 2017

Owner: qyears...@chromium.org
Status: Assigned (was: Fixed)
Still an issue.

Example build:
https://build.chromium.org/p/chromium.infra.cron/builders/wpt-importer/builds/103

https://luci-logdog.appspot.com/v/?s=chromium%2Fbb%2Fchromium.infra.cron%2Fwpt-importer%2F103%2F%2B%2Frecipes%2Fsteps%2Fupdate_wpt%2F0%2Fstdout

webkitpy.common.system.executive.ScriptError: Failed to run "['git', 'cl', 'set-close']" exit_code: 1
output: Last 500 characters of output:
 gerrit_util.AbandonChange(self._GetGerritHost(), self.GetIssue(), msg='')
  File "/mnt/data/b/depot_tools/gerrit_util.py", line 567, in AbandonChange
    return ReadHttpJsonResponse(conn)
  File "/mnt/data/b/depot_tools/gerrit_util.py", line 377, in ReadHttpJsonResponse
    fh = ReadHttpResponse(conn, accept_statuses)
  File "/mnt/data/b/depot_tools/gerrit_util.py", line 371, in ReadHttpResponse
    raise GerritError(response.status, reason)
gerrit_util.GerritError: Conflict: change is merged
step returned non-zero exit code: 1

Comment 4 by qyears...@chromium.org, Jun 18 2017

Summary: [WPT import] wpt-importer job is red when import succeeded (was: [WPT auto-import] w3c-test-autoroller job is red when import succeeded)

Comment 5 by foolip@chromium.org, Jul 3 2017

Components: Blink>Infra>Ecosystem

Comment 6 by foolip@chromium.org, Jul 3 2017

Components: -Blink>Infra>Predictability

Comment 7 by qyears...@chromium.org, Jul 26 2017

Owner: ----
Status: Available (was: Assigned)

Comment 8 by robertma@chromium.org, Sep 7 2017 

Is this still an issue? I don't recall seeing it at least during last month.

Comment 9 by qyears...@chromium.org, Sep 7 2017

Status: Fixed (was: Available)
Let's close for now and reopen if we see it again :-)
►

Sign in to add a comment