Form submission with blank target is broken |
|||||||||||
Issue descriptionApp Version (from "Chrome Settings > About Chrome"): 59.0.3045.0 iOS Version: 10.2.1 Device: iPhone Steps to reproduce: 1.) Load https://www.w3schools.com/html/html_forms.asp 2.) Tab Submit Observed behavior: Load never finishes. Popup blocking dialog is shown. Expected behavior: Child window should open. Not reproducible with M47 Stable
,
Mar 17 2017
Reproducible with M58 as well. Lindsay, could you please ask someone to bisect and update this bug with good and bad git revisions (they are in chrome://version)
,
Mar 20 2017
,
Mar 20 2017
Hi Sharon, Can you please bisect? Thanks,
,
Mar 20 2017
In crw_web_controller, we are early returning from userIsInteracting at the _lastTransferTimeInSeconds > _lastUserInteraction->time case. However, I am not sure of the cause, bisect would be very helpful.
,
Mar 20 2017
Tested in 59.0.3042.0 Canary, M58 dev, and M57 stable reproduces in all three channels. @eugebut, In comment #0 you state it is not repro in M47 stable. Our stable is M57. Was this a typo? Please let me know if you need more info.
,
Mar 20 2017
Sorry, I meant M57. I always make this mistake :(
,
Mar 20 2017
Looks like it is reproducible with M57.
,
Mar 29 2017
Any update here?
,
Mar 29 2017
,
Mar 30 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/9736d7d0d0c9999c239e43486a901b1f4a61cbdd commit 9736d7d0d0c9999c239e43486a901b1f4a61cbdd Author: michaeldo <michaeldo@chromium.org> Date: Thu Mar 30 07:36:23 2017 Form submission with blank target is broken. The UIWebView's implementation required a call to register the load of the form post request. However, this is no longer needed with WKWebView's callbacks. This removes the early |registerLoadRequest:referrer:transition:| call which was added for UIWebView and is no longer needed. TEST=Test that popups are blocked when expected, and shown when the user initiates them. I used popuptest.com to validate and there is also a link at the bottom of the page to “good” user-initiated popups that should not be blocked. The results looked good to me after this change. BUG= 702755 Review-Url: https://codereview.chromium.org/2763173002 Cr-Commit-Position: refs/heads/master@{#460688} [modify] https://crrev.com/9736d7d0d0c9999c239e43486a901b1f4a61cbdd/ios/web/web_state/js/resources/core.js [modify] https://crrev.com/9736d7d0d0c9999c239e43486a901b1f4a61cbdd/ios/web/web_state/ui/crw_web_controller.mm
,
Mar 30 2017
,
Mar 30 2017
[Auto-generated comment by a script] We noticed that this issue is targeted for M-58; it appears the fix may have landed after branch point, meaning a merge might be required. Please confirm if a merge is required here - if so add Merge-Request-58 label, otherwise remove Merge-TBD label. Thanks.
,
Mar 31 2017
,
Mar 31 2017
This bug requires manual review: Less than 21 days to go before AppStore submit on M58 Please contact the milestone owner if you have questions. Owners: amineer@(Android), cmasso@(iOS), bhthompson@(ChromeOS), govind@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Apr 3 2017
Please verify on Canary
,
Apr 3 2017
Verified in 59.0.3060.0 canary, iPhone 6 plus iOS 10.2.1. Looks good.
,
Apr 4 2017
,
Apr 4 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/dcc0449c184655ff23ce4cfdc098692055b25da1 commit dcc0449c184655ff23ce4cfdc098692055b25da1 Author: Mike Dougherty <michaeldo@chromium.org> Date: Tue Apr 04 20:50:59 2017 Form submission with blank target is broken. The UIWebView's implementation required a call to register the load of the form post request. However, this is no longer needed with WKWebView's callbacks. This removes the early |registerLoadRequest:referrer:transition:| call which was added for UIWebView and is no longer needed. TEST=Test that popups are blocked when expected, and shown when the user initiates them. I used popuptest.com to validate and there is also a link at the bottom of the page to “good” user-initiated popups that should not be blocked. The results looked good to me after this change. BUG= 702755 Review-Url: https://codereview.chromium.org/2763173002 Cr-Commit-Position: refs/heads/master@{#460688} (cherry picked from commit 9736d7d0d0c9999c239e43486a901b1f4a61cbdd) Review-Url: https://codereview.chromium.org/2801433003 . Cr-Commit-Position: refs/branch-heads/3029@{#580} Cr-Branched-From: 939b32ee5ba05c396eef3fd992822fcca9a2e262-refs/heads/master@{#454471} [modify] https://crrev.com/dcc0449c184655ff23ce4cfdc098692055b25da1/ios/web/web_state/js/resources/core.js [modify] https://crrev.com/dcc0449c184655ff23ce4cfdc098692055b25da1/ios/web/web_state/ui/crw_web_controller.mm
,
Apr 12 2017
Verified in 58.0.3029.67 beta, iPhone 6plus iOS 10.3.1. Looks good. Please check the attached video for reference. https://drive.google.com/a/google.com/file/d/0B8Cek8RsDbF8TXQ5blhNZkx4QVk/view?usp=sharing |
|||||||||||
►
Sign in to add a comment |
|||||||||||
Comment 1 by eugene...@chromium.org
, Mar 17 2017Status: Assigned (was: Untriaged)