New issue
Advanced search Search tips

Issue 702748 link

Starred by 1 user
Status: Fixed
Owner:
tbansal@chromium.org
Closed: Mar 2017
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Bug



Sign in to add a comment

"DataReductionProxyConfigTest.WarmupURL" is flaky

Project Member Reported by chromium...@appspot.gserviceaccount.com, Mar 17 2017 
"DataReductionProxyConfigTest.WarmupURL" is flaky.

This issue was created automatically by the chromium-try-flakes app. Please find the right owner to fix the respective test/step and assign this issue to them. If the step/test is infrastructure-related, please add Infra-Troopers label and change issue status to Untriaged. When done, please remove the issue from Sheriff Bug Queue by removing the Sheriff-Chromium label.

We have detected 3 recent flakes. List of all flakes can be found at https://chromium-try-flakes.appspot.com/all_flake_occurrences?key=ahVzfmNocm9taXVtLXRyeS1mbGFrZXNyMQsSBUZsYWtlIiZEYXRhUmVkdWN0aW9uUHJveHlDb25maWdUZXN0Lldhcm11cFVSTAw.

Flaky tests should be disabled within 30 minutes unless culprit CL is found and reverted. Please see more details here: https://sites.google.com/a/chromium.org/dev/developers/tree-sheriffs/sheriffing-bug-queues#triaging-auto-filed-flakiness-bugs

Comment 1 by vasi...@chromium.org, Mar 20 2017

Labels: -Sheriff-Chromium
Owner: tbansal@chromium.org
[ RUN      ] DataReductionProxyConfigTest.WarmupURL
[9596/9596] DataReductionProxyConfigTest.WarmupURL (TIMED OUT)
Retrying 1 test (retry #2)
Still waiting for the following processes to finish:
	./components_unittests --brave-new-test-launcher --gtest_flagfile=/b/swarming/w/itczjEXJ/.org.chromium.Chromium.aU6ilL/.org.chromium.Chromium.hovdX2 --no-sandbox --single-process-tests --test-launcher-bot-mode --test-launcher-output=/b/swarming/w/itczjEXJ/.org.chromium.Chromium.9Pq1vG/test_results.xml --test-launcher-print-test-stdio=always --test-launcher-summary-output=/b/swarming/w/io2c25L7/output.json
Still waiting for the following processes to finish:
	./components_unittests --brave-new-test-launcher --gtest_flagfile=/b/swarming/w/itczjEXJ/.org.chromium.Chromium.aU6ilL/.org.chromium.Chromium.hovdX2 --no-sandbox --single-process-tests --test-launcher-bot-mode --test-launcher-output=/b/swarming/w/itczjEXJ/.org.chromium.Chromium.9Pq1vG/test_results.xml --test-launcher-print-test-stdio=always --test-launcher-summary-output=/b/swarming/w/io2c25L7/output.json
Still waiting for the following processes to finish:
	./components_unittests --brave-new-test-launcher --gtest_flagfile=/b/swarming/w/itczjEXJ/.org.chromium.Chromium.aU6ilL/.org.chromium.Chromium.hovdX2 --no-sandbox --single-process-tests --test-launcher-bot-mode --test-launcher-output=/b/swarming/w/itczjEXJ/.org.chromium.Chromium.9Pq1vG/test_results.xml --test-launcher-print-test-stdio=always --test-launcher-summary-output=/b/swarming/w/io2c25L7/output.json
Still waiting for the following processes to finish:
	./components_unittests --brave-new-test-launcher --gtest_flagfile=/b/swarming/w/itczjEXJ/.org.chromium.Chromium.aU6ilL/.org.chromium.Chromium.hovdX2 --no-sandbox --single-process-tests --test-launcher-bot-mode --test-launcher-output=/b/swarming/w/itczjEXJ/.org.chromium.Chromium.9Pq1vG/test_results.xml --test-launcher-print-test-stdio=always --test-launcher-summary-output=/b/swarming/w/io2c25L7/output.json
Still waiting for the following processes to finish:
	./components_unittests --brave-new-test-launcher --gtest_flagfile=/b/swarming/w/itczjEXJ/.org.chromium.Chromium.aU6ilL/.org.chromium.Chromium.hovdX2 --no-sandbox --single-process-tests --test-launcher-bot-mode --test-launcher-output=/b/swarming/w/itczjEXJ/.org.chromium.Chromium.9Pq1vG/test_results.xml --test-launcher-print-test-stdio=always --test-launcher-summary-output=/b/swarming/w/io2c25L7/output.json
[1957:1960:0318/022138.866946:3593877163:ERROR:kill_posix.cc(84)] Unable to terminate process group 6988: No such process

The test times out occasionally. Assigning to tbansal@ as the most active contributor and owner of the code.

Comment 2 by tbansal@chromium.org, Mar 20 2017

Status: Started (was: Untriaged)
Project Member

Comment 3 by bugdroid1@chromium.org, Mar 22 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/dfc3e7204e434185cbaa0d6cb48ae0b37481f007

commit dfc3e7204e434185cbaa0d6cb48ae0b37481f007
Author: tbansal <tbansal@chromium.org>
Date: Wed Mar 22 23:01:37 2017

Fix the flaky Warmup URL test in data reduction proxy

Remove the part of the test that waits for the fetch to succeed. The test
is flaking because sometimes the URL may be fetched before the callback
is set. This causes the run loop to wait forever.

BUG= 702748 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_cronet_tester

Review-Url: https://codereview.chromium.org/2765763003
Cr-Commit-Position: refs/heads/master@{#458917}

[modify] https://crrev.com/dfc3e7204e434185cbaa0d6cb48ae0b37481f007/components/data_reduction_proxy/core/browser/data_reduction_proxy_config.cc
[modify] https://crrev.com/dfc3e7204e434185cbaa0d6cb48ae0b37481f007/components/data_reduction_proxy/core/browser/data_reduction_proxy_config.h
[modify] https://crrev.com/dfc3e7204e434185cbaa0d6cb48ae0b37481f007/components/data_reduction_proxy/core/browser/data_reduction_proxy_config_test_utils.h
[modify] https://crrev.com/dfc3e7204e434185cbaa0d6cb48ae0b37481f007/components/data_reduction_proxy/core/browser/data_reduction_proxy_config_unittest.cc

Comment 4 by tbansal@chromium.org, Mar 22 2017

Labels: M-59
Status: Fixed (was: Started)
►

Sign in to add a comment