New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 702747 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Mar 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Bug

Blocking:
issue 645996



Sign in to add a comment

Get the gray background for system modals in mash.

Project Member Reported by moshayedi@chromium.org, Mar 17 2017

Issue description

Currently we don't get the gray background for system modals in mash. For example, a javascript alert window.

This is because we don't add system modals to SystemModalContainer.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Mar 21 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/92b3b48f68b255d6acc8efee1ac5682684676bba

commit 92b3b48f68b255d6acc8efee1ac5682684676bba
Author: moshayedi <moshayedi@chromium.org>
Date: Tue Mar 21 20:27:46 2017

Add system modals to the proper container in mus+ash.

System modal windows should be added to kShellWindowId_SystemModalContainer so
we get effects like gray background for them.

BUG= 702747 

Review-Url: https://codereview.chromium.org/2759643003
Cr-Commit-Position: refs/heads/master@{#458533}

[modify] https://crrev.com/92b3b48f68b255d6acc8efee1ac5682684676bba/ash/mus/window_manager.cc
[modify] https://crrev.com/92b3b48f68b255d6acc8efee1ac5682684676bba/ash/mus/window_manager.h
[modify] https://crrev.com/92b3b48f68b255d6acc8efee1ac5682684676bba/mash/simple_wm/simple_wm.cc
[modify] https://crrev.com/92b3b48f68b255d6acc8efee1ac5682684676bba/mash/simple_wm/simple_wm.h
[modify] https://crrev.com/92b3b48f68b255d6acc8efee1ac5682684676bba/services/ui/demo/mus_demo_internal.cc
[modify] https://crrev.com/92b3b48f68b255d6acc8efee1ac5682684676bba/services/ui/demo/mus_demo_internal.h
[modify] https://crrev.com/92b3b48f68b255d6acc8efee1ac5682684676bba/services/ui/test_wm/test_wm.cc
[modify] https://crrev.com/92b3b48f68b255d6acc8efee1ac5682684676bba/services/ui/ws/window_manager_client_unittest.cc
[modify] https://crrev.com/92b3b48f68b255d6acc8efee1ac5682684676bba/services/ui/ws/window_server_test_base.cc
[modify] https://crrev.com/92b3b48f68b255d6acc8efee1ac5682684676bba/services/ui/ws/window_server_test_base.h
[modify] https://crrev.com/92b3b48f68b255d6acc8efee1ac5682684676bba/ui/aura/mus/window_manager_delegate.h
[modify] https://crrev.com/92b3b48f68b255d6acc8efee1ac5682684676bba/ui/aura/mus/window_tree_client.cc
[modify] https://crrev.com/92b3b48f68b255d6acc8efee1ac5682684676bba/ui/aura/test/aura_test_base.cc
[modify] https://crrev.com/92b3b48f68b255d6acc8efee1ac5682684676bba/ui/aura/test/aura_test_base.h

Status: Fixed (was: Started)
Components: -Internals>MUS Internals>Services>WindowService
Components: -MUS>Phase>1

Sign in to add a comment