New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 702745 link

Starred by 1 user
Status: Fixed
Owner:
sergeyu@chromium.org
Closed: Mar 2017
Cc:
█ zijiehe@chromium.org
guidou@chromium.org
niklase@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 3
Type: Bug



Sign in to add a comment

DesktopCapturer::Create(Window|Screen)Capturer() do not handle failures correctly.

Project Member Reported by sergeyu@chromium.org, Mar 17 2017 
CreateRawScreenCapturer() and CreateRawWindowCapturer() in DesktopCapturer are allowed to return nullptr, but CreateWindowCapturer() and CreateScreenCapturer() do not handle this case.
Project Member

Comment 1 by bugdroid1@chromium.org, Mar 17 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/external/webrtc.git/+/3eba2d82737932660aae18fe4ad169414a3c3313

commit 3eba2d82737932660aae18fe4ad169414a3c3313
Author: sergeyu <sergeyu@chromium.org>
Date: Fri Mar 17 22:33:27 2017

Fix DesktopCapturer constructors to handle failures properly.

CreateRawScreenCapturer() and CreateRawWindowCapturer() in
DesktopCapturer are allowed to return nullptr when capturer cannot be
initialized for some reason. CreateWindowCapturer() and
CreateScreenCapturer() in DesktopCapturer were not handling this case
correctly, which may lead to crash.

BUG= chromium:702745 

Review-Url: https://codereview.webrtc.org/2754403002
Cr-Commit-Position: refs/heads/master@{#17298}

[modify] https://crrev.com/3eba2d82737932660aae18fe4ad169414a3c3313/webrtc/modules/desktop_capture/desktop_capturer.cc

Comment 2 by sergeyu@chromium.org, Mar 31 2017

Status: Fixed (was: Started)

Comment 3 by anatolid@chromium.org, Apr 24 2017

Labels: M-59
►

Sign in to add a comment