New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 702739 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Apr 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

Add trace event in NavigationControllerImpl::GoToIndex.

Project Member Reported by sunjian@chromium.org, Mar 17 2017

Issue description

Add trace event in NavigationControllerImpl::GoToIndex.

Currently, we have added trace events in NavigationControllerImpl::back/forward functions. We just found out that both of them call NavigationControllerImpl::GoToIndex. Therefore, only adding one trace event in NavigationControllerImpl::GoToIndex will cover both of NavigationControllerImpl::back and forward calls.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Mar 21 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/30574a61c2972095e8dff5a0dc0f7c66e1fcf092

commit 30574a61c2972095e8dff5a0dc0f7c66e1fcf092
Author: sunjian <sunjian@chromium.org>
Date: Tue Mar 21 21:39:44 2017

Add trace event in NavigationControllerImpl::GoToIndex.

Currently, we have added trace events in NavigationControllerImpl::back/forward
functions. We just found out that both of them call NavigationControllerImpl::GoToIndex.
Therefore, only adding one trace event in NavigationControllerImpl::GoToIndex will
cover both of NavigationControllerImpl::back and forward calls.

BUG= 702739 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation

Review-Url: https://codereview.chromium.org/2759523003
Cr-Commit-Position: refs/heads/master@{#458558}

[modify] https://crrev.com/30574a61c2972095e8dff5a0dc0f7c66e1fcf092/content/browser/frame_host/navigation_controller_impl.cc

Status: Fixed (was: Assigned)

Sign in to add a comment