Issue metadata
Sign in to add a comment
|
Can't press space to activate the focused tab |
||||||||||||||||||||||
Issue descriptionChrome Version: 59.0.3044.0 OS: macOS 10.12.3 What steps will reproduce the problem? (1) Make sure that chrome://flags/#tab-strip-keyboard-focus is enabled. (2) Focus a tab's title. (3) Press the space bar. What is the expected result? The tab becomes active. What happens instead? Nothing happens. Other controls (like the close button) respond to the space bar.
,
Apr 21 2017
,
Aug 3 2017
,
Oct 12 2017
,
Oct 13 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/2bf92ec5a3325be3a00eb5d66e0937c6983a768d commit 2bf92ec5a3325be3a00eb5d66e0937c6983a768d Author: Elly Fong-Jones <ellyjones@chromium.org> Date: Fri Oct 13 20:54:08 2017 cocoa: use space to activate tabs and refactor tab keypress handling This change: 1. Moves event handling from keyUp: to performClick: 2. Activates tabs when space is pressed on them 3. No longer activates tabs when return is pressed on them Bug: 702735 Change-Id: I44e2278d93603de664fbae2d6a2c980262130c8f Reviewed-on: https://chromium-review.googlesource.com/716340 Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Reviewed-by: Sidney San MartÃn <sdy@chromium.org> Cr-Commit-Position: refs/heads/master@{#508810} [modify] https://crrev.com/2bf92ec5a3325be3a00eb5d66e0937c6983a768d/chrome/browser/ui/cocoa/tabs/tab_controller.h [modify] https://crrev.com/2bf92ec5a3325be3a00eb5d66e0937c6983a768d/chrome/browser/ui/cocoa/tabs/tab_controller.mm [modify] https://crrev.com/2bf92ec5a3325be3a00eb5d66e0937c6983a768d/chrome/browser/ui/cocoa/tabs/tab_controller_unittest.mm [modify] https://crrev.com/2bf92ec5a3325be3a00eb5d66e0937c6983a768d/chrome/browser/ui/cocoa/tabs/tab_view.h
,
Oct 16 2017
|
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by dmazz...@chromium.org
, Mar 27 2017