Issue 702715 link

Starred by 1 user

Issue metadata

Status:	Verified
Owner:	lijeffrey@chromium.org
Closed:	Mar 2017
Cc:	█ robert...@chromium.org chanli@chromium.org lijeffrey@chromium.org liaoyuke@chromium.org st...@chromium.org
Components:	Tools>Test>FindIt>Flakiness
EstimatedDays:	----
NextAction:	----
OS:	----
Pri:	1
Type:	Bug

Show regression rang correctly on the flakiness trend diagram

Project Member Reported by st...@chromium.org, Mar 17 2017

Issue description

Currently, the regression range at a data point is the blame list of that specific build.

However, two data points might not be consecutive builds on Waterfall. Thus it is misleading from a user's perspective.

Each data point has a commit position, and the regression range should be between two commit positions instead.

Project Member

Comment 1 by bugdroid1@chromium.org, Mar 20 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/infra/+/02df4a45990626f941244f558485135c1a9e5251

commit 02df4a45990626f941244f558485135c1a9e5251
Author: Jeffrey Li <lijeffrey@chromium.org>
Date: Mon Mar 20 23:39:19 2017

[Findit] Flake Analyzer - Show regression range as between points

Sample new UI: https://lijeffrey-dot-findit-for-me.appspot.com/waterfall/check-flake?key=ag9zfmZpbmRpdC1mb3ItbWVy1AELEhdNYXN0ZXJGbGFrZUFuYWx5c2lzUm9vdCKdAWNocm9taXVtLndpbi9XaW4gNyBUZXN0cyB4NjQgKDEpLzIxNzYzL2Jyb3dzZXJfdGVzdHMvUTNKbFpHVnVkR2xoYkUxaGJtRm5aWEpDY205M2MyVnlWR1Z6ZEM1UFluTnZiR1YwWlVoMGRIQkRjbVZrWlc1MGFXRnNUVzkyWldSUGJrMXBaM0poZEdsdmJsUnZTSE4wYzFOcGRHVT0MCxITTWFzdGVyRmxha2VBbmFseXNpcxgBDA

BUG= 702715 

Change-Id: I1c1959955ea7e223af495b94f2f0bd5e6fc644d3
Reviewed-on: https://chromium-review.googlesource.com/457172
Commit-Queue: Shuotao Gao <stgao@chromium.org>
Reviewed-by: Roberto Carrillo <robertocn@chromium.org>
Reviewed-by: Shuotao Gao <stgao@chromium.org>
Reviewed-by: Chan Li <chanli@chromium.org>

[modify] https://crrev.com/02df4a45990626f941244f558485135c1a9e5251/appengine/findit/handlers/flake/check_flake.py
[modify] https://crrev.com/02df4a45990626f941244f558485135c1a9e5251/appengine/findit/handlers/flake/test/check_flake_test.py
[modify] https://crrev.com/02df4a45990626f941244f558485135c1a9e5251/appengine/findit/templates/flake/result.html

Comment 2 by lijeffrey@chromium.org, Mar 21 2017

Status: Verified (was: Assigned)

►

Issue 702715 link

Issue metadata

Show regression rang correctly on the flakiness trend diagram

Issue description

Comment 1 by bugdroid1@chromium.org, Mar 20 2017

Comment 1 Deleted

Comment 2 by lijeffrey@chromium.org, Mar 21 2017

Comment 2 Deleted

Sign in to add a comment