New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 702712 link

Starred by 1 user
Status: Fixed
Owner:
mattreynolds@chromium.org
Closed: Apr 2017
Cc:
█ aelias@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 1
Type: Bug


Show other hotlists

Hotlists containing this issue:
Gamepad


Sign in to add a comment

"GamepadProviderTest.Sanitization" is flaky

Project Member Reported by chromium...@appspot.gserviceaccount.com, Mar 17 2017 
"GamepadProviderTest.Sanitization" is flaky.

This issue was created automatically by the chromium-try-flakes app. Please find the right owner to fix the respective test/step and assign this issue to them. If the step/test is infrastructure-related, please add Infra-Troopers label and change issue status to Untriaged. When done, please remove the issue from Sheriff Bug Queue by removing the Sheriff-Chromium label.

We have detected 7 recent flakes. List of all flakes can be found at https://chromium-try-flakes.appspot.com/all_flake_occurrences?key=ahVzfmNocm9taXVtLXRyeS1mbGFrZXNyKwsSBUZsYWtlIiBHYW1lcGFkUHJvdmlkZXJUZXN0LlNhbml0aXphdGlvbgw.

Flaky tests should be disabled within 30 minutes unless culprit CL is found and reverted. Please see more details here: https://sites.google.com/a/chromium.org/dev/developers/tree-sheriffs/sheriffing-bug-queues#triaging-auto-filed-flakiness-bugs

Comment 1 by vasi...@chromium.org, Mar 20 2017

Components: IO>Gamepad
Similar failures have already happened in  https://crbug.com/640086 .

[ RUN      ] GamepadProviderTest.Sanitization
../../device/gamepad/gamepad_provider_unittest.cc:258: Failure
Value of: output.items[0].buttonsLength
  Actual: 0
Expected: 1u
Which is: 1
../../device/gamepad/gamepad_provider_unittest.cc:261: Failure
Value of: output.items[0].axesLength
  Actual: 0
Expected: 1u
Which is: 1
[  FAILED  ] GamepadProviderTest.Sanitization (81 ms)
Project Member

Comment 2 by bugdroid1@chromium.org, Mar 20 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3a63ad337f6b5dd926292b496f4cb9bb14d4594d

commit 3a63ad337f6b5dd926292b496f4cb9bb14d4594d
Author: Vasilii Sukhanov <vasilii@chromium.org>
Date: Mon Mar 20 16:43:51 2017

Disable GamepadProviderTest.Sanitization on Linux and CrOS.

BUG= 702712 
TBR=bajones@chromium.org

Review-Url: https://codereview.chromium.org/2757293003 .
Cr-Commit-Position: refs/heads/master@{#458090}

[modify] https://crrev.com/3a63ad337f6b5dd926292b496f4cb9bb14d4594d/device/gamepad/gamepad_provider_unittest.cc

Comment 3 by vasi...@chromium.org, Mar 20 2017

Labels: -Sheriff-Chromium
Owner: bajones@chromium.org
Assigning to bajones@chromium.org for analysis

Comment 4 by aelias@chromium.org, Mar 25 2017

Cc: aelias@chromium.org
Hmm, I've tried to reproduce this a few hundred times locally under ASAN Linux, but no luck, it always passes.  This is at r459595 and with GN args:

dcheck_always_on = true
is_asan = true
is_component_build = false
is_debug = false
is_lsan = true
strip_absolute_paths_from_debug_symbols = true
symbol_level = 1

ninja -C out/$OUTPATH device_unittests && while out/$OUTPATH/device_unittests --gtest_filter=GamepadProviderTest.*; do :; done

Comment 5 by mattreynolds@chromium.org, Apr 5 2017

Labels: OS-All
Status: Available (was: Untriaged)
We should take another shot at reproing this. Added to the DeviceAPI-Google-Team hotlist.

Comment 6 by scheib@chromium.org, Apr 12 2017

Owner: mattreynolds@chromium.org
Status: Started (was: Available)

Comment 7 by mattreynolds@chromium.org, Apr 14 2017

Status: Fixed (was: Started)
I think this is fixed by https://codereview.chromium.org/2820563003, marking as Fixed and reenabling the test on all platforms.

I hadn't seen this fail before, but I think it is likely caused by the same race condition as  crbug.com/692219 . I ran the patched unittest 1000x on OSX, Linux, and Android and saw no failures.  That said, I hadn't seen any failures prior to the change.

Please reopen if this test is still flaky!

Comment 8 by reillyg@chromium.org, Apr 27 2017

Components: -IO>Gamepad Blink>GamepadAPI
►

Sign in to add a comment