New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 702710 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Jul 2017
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Task



Sign in to add a comment

Clean up namespaces used in chromeos printing

Project Member Reported by justincarlson@chromium.org, Mar 17 2017

Issue description

Right now we have a weird mishmash of stuff in ::chromeos::printing and ::chromeos, across several locations.  This should be made consistent.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Jul 18 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5c3feaef653f0f612759f9fb7fc35d1f67a8cbf7

commit 5c3feaef653f0f612759f9fb7fc35d1f67a8cbf7
Author: justincarlson <justincarlson@chromium.org>
Date: Tue Jul 18 01:42:05 2017

Make chromeos CUPS printing code namespaces consistent.

Previously printing code was in a mix of chromeos:: and
chromeos::printing.  This standardizes everything on chromeos::,
removing the chromeos::printing namespace completely.

These changes are almost entirely mechanical.  I did rename the factory function "CreateProvider" to the less generic "CreatePpdProvider" since it's now in ::chromeos directly.

BUG= 702710 

Review-Url: https://codereview.chromium.org/2975013002
Cr-Commit-Position: refs/heads/master@{#487334}

[modify] https://crrev.com/5c3feaef653f0f612759f9fb7fc35d1f67a8cbf7/chrome/browser/chromeos/printing/ppd_provider_factory.cc
[modify] https://crrev.com/5c3feaef653f0f612759f9fb7fc35d1f67a8cbf7/chrome/browser/chromeos/printing/ppd_provider_factory.h
[modify] https://crrev.com/5c3feaef653f0f612759f9fb7fc35d1f67a8cbf7/chrome/browser/chromeos/printing/printer_configurer.cc
[modify] https://crrev.com/5c3feaef653f0f612759f9fb7fc35d1f67a8cbf7/chrome/browser/chromeos/printing/specifics_translation.cc
[modify] https://crrev.com/5c3feaef653f0f612759f9fb7fc35d1f67a8cbf7/chrome/browser/chromeos/printing/specifics_translation.h
[modify] https://crrev.com/5c3feaef653f0f612759f9fb7fc35d1f67a8cbf7/chrome/browser/chromeos/printing/specifics_translation_unittest.cc
[modify] https://crrev.com/5c3feaef653f0f612759f9fb7fc35d1f67a8cbf7/chrome/browser/chromeos/printing/synced_printers_manager.cc
[modify] https://crrev.com/5c3feaef653f0f612759f9fb7fc35d1f67a8cbf7/chrome/browser/chromeos/printing/synced_printers_manager_unittest.cc
[modify] https://crrev.com/5c3feaef653f0f612759f9fb7fc35d1f67a8cbf7/chrome/browser/chromeos/printing/usb_printer_detector.cc
[modify] https://crrev.com/5c3feaef653f0f612759f9fb7fc35d1f67a8cbf7/chrome/browser/ui/webui/print_preview/printer_backend_proxy_chromeos.cc
[modify] https://crrev.com/5c3feaef653f0f612759f9fb7fc35d1f67a8cbf7/chrome/browser/ui/webui/settings/chromeos/cups_printers_handler.cc
[modify] https://crrev.com/5c3feaef653f0f612759f9fb7fc35d1f67a8cbf7/chrome/browser/ui/webui/settings/chromeos/cups_printers_handler.h
[modify] https://crrev.com/5c3feaef653f0f612759f9fb7fc35d1f67a8cbf7/chromeos/printing/ppd_cache.cc
[modify] https://crrev.com/5c3feaef653f0f612759f9fb7fc35d1f67a8cbf7/chromeos/printing/ppd_cache.h
[modify] https://crrev.com/5c3feaef653f0f612759f9fb7fc35d1f67a8cbf7/chromeos/printing/ppd_cache_unittest.cc
[modify] https://crrev.com/5c3feaef653f0f612759f9fb7fc35d1f67a8cbf7/chromeos/printing/ppd_provider.cc
[modify] https://crrev.com/5c3feaef653f0f612759f9fb7fc35d1f67a8cbf7/chromeos/printing/ppd_provider.h
[modify] https://crrev.com/5c3feaef653f0f612759f9fb7fc35d1f67a8cbf7/chromeos/printing/ppd_provider_unittest.cc
[modify] https://crrev.com/5c3feaef653f0f612759f9fb7fc35d1f67a8cbf7/chromeos/printing/printer_translator.cc
[modify] https://crrev.com/5c3feaef653f0f612759f9fb7fc35d1f67a8cbf7/chromeos/printing/printer_translator.h
[modify] https://crrev.com/5c3feaef653f0f612759f9fb7fc35d1f67a8cbf7/chromeos/printing/printer_translator_unittest.cc
[modify] https://crrev.com/5c3feaef653f0f612759f9fb7fc35d1f67a8cbf7/chromeos/printing/printing_constants.h

Status: Fixed (was: Assigned)

Sign in to add a comment