New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 702709 link

Starred by 1 user

Issue metadata

Status: Verified
Owner:
Closed: Mar 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug



Sign in to add a comment

Kip: Headphone & Mic jack still shows in Uber tray though unplugged in Suspended state

Project Member Reported by pgangishetty@google.com, Mar 17 2017

Issue description

Chrome Version: 58.0.3029.19
OS:9334.13.0 (Official Build) dev-channel kip
Firmware: Google_Kip.5216.227.78

What steps will reproduce the problem?
(1)Sign in on Device
(2)Plug in 3.5mm headphones
(3)Suspend the device by (a)Closing the lid OR (b)powerd_dbus_suspend
(4)Unplug 3.5mm headphones
(5)Check Uber tray

What is the expected result?
Headphone option should not be displayed in Uber tray

What happens instead?
Headphone option still shows in the tray as active (screenshot). Reproducible all the times.

Please use labels and text to provide additional information.
Logs and screenshot attached.  

For graphics-related bugs, please copy/paste the contents of the about:gpu
page at the end of this report.

 
Step #5 updated:

(5)Resume the device and Check Uber tray

Comment 3 by dgreid@chromium.org, Mar 17 2017

Cc: rajatja@chromium.org
Owner: hychao@chromium.org
One more baytrail 4.4 issue?
Summary: Kip: Headphone & Mic jack still shows in Uber tray though unplugged in Suspended state (was: Kip: Headphone & Mic jack still shows in Uber tray though unplugged in Suspended)

Comment 5 by hychao@chromium.org, Mar 20 2017

Status: Started (was: Untriaged)
Seems we need to port https://chromium-review.googlesource.com/190114 for 4.4

Comment 6 by hychao@chromium.org, Mar 20 2017

Fix uploaded to https://chromium-review.googlesource.com/#/c/456666/

Note we have 3 Baytrail boards use kernel 4.4 in M57 so we might want to merge  there.
Project Member

Comment 7 by bugdroid1@chromium.org, Mar 22 2017

Labels: merge-merged-chromeos-4.4
The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/kernel/+/0ea1b7e1beccc15bab6495a3d98b39eb877d9828

commit 0ea1b7e1beccc15bab6495a3d98b39eb877d9828
Author: Dmitry Torokhov <dtor@chromium.org>
Date: Wed Mar 22 20:29:38 2017

FROMLIST: ASoC: jack - check status of GPIO-based pins on resume

For GPIO-backed pins that are not configured as wakeup sources, we may
miss change in their state that happens while system is suspended. Let's
use PM notifier to refresh their state upon resume.

BUG= chromium:702709 
TEST=build

(am from https://patchwork.kernel.org/patch/9637845/)
Signed-off-by: Dmitry Torokhov <dtor@chromium.org>
Change-Id: I80fed3cf2a248f0c14c6b919d506f674e0e5d376
Reviewed-on: https://chromium-review.googlesource.com/457411
Reviewed-by: Dylan Reid <dgreid@chromium.org>

[modify] https://crrev.com/0ea1b7e1beccc15bab6495a3d98b39eb877d9828/include/sound/soc.h
[modify] https://crrev.com/0ea1b7e1beccc15bab6495a3d98b39eb877d9828/sound/soc/soc-jack.c

Comment 8 by dtor@chromium.org, Mar 23 2017

Labels: Merge-Request-58 Merge-Request-57

Comment 9 by dtor@chromium.org, Mar 23 2017

Cc: dtor@chromium.org
Project Member

Comment 10 by sheriffbot@chromium.org, Mar 24 2017

Labels: -Merge-Request-58 Hotlist-Merge-Approved Merge-Approved-58
Your change meets the bar and is auto-approved for M58. Please go ahead and merge the CL to branch 3029 manually. Please contact milestone owner if you have questions.
Owners: amineer@(Android), cmasso@(iOS), bhthompson@(ChromeOS), govind@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Project Member

Comment 11 by bugdroid1@chromium.org, Mar 24 2017

Labels: merge-merged-release-R58-9334.B-chromeos-4.4
The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/kernel/+/bed311ce7c6eaaef0b244f3392af914a20394274

commit bed311ce7c6eaaef0b244f3392af914a20394274
Author: Dmitry Torokhov <dtor@chromium.org>
Date: Fri Mar 24 17:11:32 2017

FROMLIST: ASoC: jack - check status of GPIO-based pins on resume

For GPIO-backed pins that are not configured as wakeup sources, we may
miss change in their state that happens while system is suspended. Let's
use PM notifier to refresh their state upon resume.

BUG= chromium:702709 
TEST=build

(am from https://patchwork.kernel.org/patch/9637845/)
Signed-off-by: Dmitry Torokhov <dtor@chromium.org>
Change-Id: I80fed3cf2a248f0c14c6b919d506f674e0e5d376
Reviewed-on: https://chromium-review.googlesource.com/457411
Reviewed-by: Dylan Reid <dgreid@chromium.org>
(cherry picked from commit 0ea1b7e1beccc15bab6495a3d98b39eb877d9828)
Reviewed-on: https://chromium-review.googlesource.com/459122

[modify] https://crrev.com/bed311ce7c6eaaef0b244f3392af914a20394274/include/sound/soc.h
[modify] https://crrev.com/bed311ce7c6eaaef0b244f3392af914a20394274/sound/soc/soc-jack.c

Comment 12 Deleted

Comment 13 by dtor@chromium.org, Mar 27 2017

Labels: -Merge-Request-57 -Merge-Approved-58
Status: Fixed (was: Started)
Not all Baytrail boards use GPIOs for pins so I think we can live without this fix in 57.
Status: Verified (was: Fixed)
Verified with version 58.0.3029.39 beta/9334.23.0 

Sign in to add a comment