New issue
Advanced search Search tips

Issue 702700 link

Starred by 2 users

Issue metadata

Status: WontFix
Owner:
Closed: Jun 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Feature
Proj-XR



Sign in to add a comment

Improve WebVR E2E Test Coverage

Project Member Reported by bsheedy@chromium.org, Mar 17 2017

Issue description

The capability to write and continuously run WebVR end-to-end tests are now in place, but there is still very little test coverage. Tests should be written to cover existing functionality, and any additions/modifications to WebVR should have appropriate tests added.
 
The infrastructure is Android-only at the moment.
Project Member

Comment 2 by bugdroid1@chromium.org, Mar 20 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/43e217685e5c263404a0b71eadd5f3a30ff59ccf

commit 43e217685e5c263404a0b71eadd5f3a30ff59ccf
Author: bsheedy <bsheedy@chromium.org>
Date: Mon Mar 20 21:34:31 2017

Add screen tap WebVR tests

Adds two new WebVR e2e tests verifying that screen taps are registered in VR
when using Cardboard but not Daydream View.

Also increases the timeout of certain Javascript executions since 50 ms was
sometimes (although rarely) causing flakiness.

Re-names the VR restrictions to more clearly differentiate between restrictions
on Daydream-readiness and restrictions on the currently paired viewer.

BUG= 702700 

Review-Url: https://codereview.chromium.org/2753303002
Cr-Commit-Position: refs/heads/master@{#458195}

[modify] https://crrev.com/43e217685e5c263404a0b71eadd5f3a30ff59ccf/chrome/android/javatests/src/org/chromium/chrome/browser/vr_shell/VrShellTest.java
[modify] https://crrev.com/43e217685e5c263404a0b71eadd5f3a30ff59ccf/chrome/android/javatests/src/org/chromium/chrome/browser/vr_shell/WebVrTest.java
[modify] https://crrev.com/43e217685e5c263404a0b71eadd5f3a30ff59ccf/chrome/test/android/javatests/src/org/chromium/chrome/test/ChromeInstrumentationTestRunner.java
[modify] https://crrev.com/43e217685e5c263404a0b71eadd5f3a30ff59ccf/chrome/test/android/javatests/src/org/chromium/chrome/test/util/ChromeRestriction.java
[add] https://crrev.com/43e217685e5c263404a0b71eadd5f3a30ff59ccf/chrome/test/data/android/webvr_instrumentation/html/test_screen_taps_not_registered_on_daydream.html
[add] https://crrev.com/43e217685e5c263404a0b71eadd5f3a30ff59ccf/chrome/test/data/android/webvr_instrumentation/html/test_screen_taps_registered_on_cardboard.html

Project Member

Comment 3 by bugdroid1@chromium.org, Apr 7 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d2bb15449ca92f88f8f4e9f6a93a96d567b00e2c

commit d2bb15449ca92f88f8f4e9f6a93a96d567b00e2c
Author: bsheedy <bsheedy@chromium.org>
Date: Fri Apr 07 18:30:49 2017

Add WebVR device capability e2e test

Tests that the device capabilities reported by WebVR match expectations,
although currently all tested devices have the same expectations.

Automates one of our manual test cases.

BUG= 702700 

Review-Url: https://codereview.chromium.org/2794383002
Cr-Commit-Position: refs/heads/master@{#462934}

[modify] https://crrev.com/d2bb15449ca92f88f8f4e9f6a93a96d567b00e2c/chrome/android/javatests/src/org/chromium/chrome/browser/vr_shell/WebVrTest.java
[add] https://crrev.com/d2bb15449ca92f88f8f4e9f6a93a96d567b00e2c/chrome/test/data/android/webvr_instrumentation/html/test_device_capabilities_match_expectations.html

Labels: VR-BBB
Labels: hotlist-initial-vr-browser
Labels: -hotlist-initial-vr-browser

Comment 7 by tiborg@chromium.org, May 10 2017

Cc: tiborg@chromium.org
Labels: VR-Test
Components: -UI>Browser>VR Blink>WebVR
Labels: -VR-BBB
Owner: bsheedy@chromium.org
Status: Assigned (was: Untriaged)
bsheedy: What does this bug track now? Should we close it and file new issues for specific gaps?
Status: WontFix (was: Assigned)
Yeah, closing it sounds good. Individual issues are being filed for missing tests so this is unnecessary.
Components: Blink>WebXR

Sign in to add a comment