[Mac] Page prevents entering fullscreen via keyboard shortcut |
|||||||||
Issue descriptionChrome Version: 58.0.3029.19 OS: macOS What steps will reproduce the problem? (1) Go to https://sfiera.net/~sfiera/prevent-default.html (2) Press Control-Cmd-f to enter fullscreen mode What is the expected result? The browser window should enter fullscreen mode. What happens instead? The browser window does not enter fullscreen mode.
,
Mar 17 2017
It also doesn't work with Safari when you visit the link from step 1 and try to enter fullscreen via Control-Cmd-f .
,
Mar 17 2017
Interesting - it sounds like it's perhaps not a regression in Chrome.
,
Mar 17 2017
I downloaded a very old Snapshot (15.0.875.0) and it doesn't work there, too. https://commondatastorage.googleapis.com/chromium-browser-snapshots/index.html?prefix=Mac/100008/
,
Mar 17 2017
Thanks, removing the bisect label.Please remove RBS if needed.
,
Mar 17 2017
,
Mar 17 2017
,
Mar 29 2017
Is this a false-alarm?
,
Mar 29 2017
I don't think so - it's still happening in the latest Canary.
,
Mar 29 2017
No, I mean if the the behavior is consistent even on a very old version, I am definitely not the right person to change the behavior. What I can tell is that according to the code, the full-screen shortcut is only guaranteed to work in full-screen mode. Mike Wasserman (msw@, CCed) may be the right person to answer the motivation of this behavior.
,
Mar 29 2017
I don't know much about intended Mac UI behavior offhand. Agreed that zijiehe@ is not the right owner. shrike@, can you triage?
,
Mar 29 2017
> No, I mean if the the behavior is consistent even on a very old version, I'm not sure. > I am definitely not the right person to change the behavior. What I can tell is that according to the code, the full-screen shortcut is only guaranteed to work in full-screen mode. Maybe web fullscreen? The shortcut doesn't work even if Chrome is in app fullscreen. Can you give me a pointer to the code?
,
Mar 29 2017
https://cs.chromium.org/chromium/src/chrome/browser/ui/browser_command_controller.cc?rcl=1c59eda4e5a4c7427f355ed752e94f43561604a3&l=190 is the place to control full-screen shortcut in full-screen mode. But I cannot tell where preventDefault() takes effect.
,
Jan 24 2018
Moving back to triage
,
Jan 24 2018
I still can reproduce it with Chrome Canary 66.0.3330.0 on macOS 10.12.6.
,
Jan 25 2018
This is the same way F11 works on Windows as well. shrike@ is this a UX request to change? Doesn't seem like a blink issue but the fact that the browser isn't marking these keys as reserved.
,
Jan 30 2018
I don't think there's anything to do here. We can re-open if someone feels a strong desire to change the current behavior. |
|||||||||
►
Sign in to add a comment |
|||||||||
Comment 1 by ligim...@chromium.org
, Mar 17 2017