New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 702690 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner: ----
Closed: Mar 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

[Findit] Try job result is wrong after a rerun

Project Member Reported by chanli@chromium.org, Mar 17 2017

Issue description

Url:https://findit-for-me.appspot.com/waterfall/failure?url=https://luci-milo.appspot.com/buildbot/chromium.chrome/Google%20Chrome%20Win/16241

After 2 reruns of this build, WfTryJob.compile_results is strangely wrong:
[
  {
    "report": {
      "result": {
        "5484f6789849305b5a86787dd9710c0f682e77e0": "failed", 
        "5f6c9c530b8cda7429c2ca86655439b5ea952b40": "failed", 
        "c3cb7d84db9a7d99ae917f32c1acca0f44ca3b22": "failed", 
        "e5ec3568878feddb6978cb2a352e1226ccb74bd2": "failed"
      }, 
      "culprit": "c3cb7d84db9a7d99ae917f32c1acca0f44ca3b22", 
      "metadata": {
        "use_bisect": true, 
        "regression_range_size": 12, 
        "sub_ranges": [
          [
            null, 
            "c3cb7d84db9a7d99ae917f32c1acca0f44ca3b22", 
            "e5ec3568878feddb6978cb2a352e1226ccb74bd2", 
            "cba3aa3a044b578b02a8c237f0bde012260fcf9e", 
            "5484f6789849305b5a86787dd9710c0f682e77e0", 
            "38c960952a3a5b5988c6bbae897451065202d250", 
            "a1f25a6c5efe6eaf1f5fd5d32593f60e4586e6fe", 
            "5f6c9c530b8cda7429c2ca86655439b5ea952b40", 
            "a46782374d15333661c7d3295f7c7413af92b4c0", 
            "42561dc4b39708c610a0149fb61b6f17c0e21f8e", 
            "815054b5918e1d631c4208b06b83d1e833ef6240", 
            "58e4a73d8f76c0683d60cca2a487e88090b05fce", 
            "066ce03b77d3f3802a67e59811f07c9e5fc3e8ab"
          ]
        ]
      }
    }, 
    "url": "http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_variable_chrome/builds/84", 
    "try_job_id": "8984939366240509760", 
    "culprit": {
      "compile": {
        "url": "https://codereview.chromium.org/2756713002", 
        "revision": "c3cb7d84db9a7d99ae917f32c1acca0f44ca3b22", 
        "commit_position": 457493, 
        "repo_name": "chromium"
      }
    }
  }, 
  {
    "report": {
      "result": {
        "5484f6789849305b5a86787dd9710c0f682e77e0": "failed", 
        "5f6c9c530b8cda7429c2ca86655439b5ea952b40": "failed", 
        "c3cb7d84db9a7d99ae917f32c1acca0f44ca3b22": "failed", 
        "e5ec3568878feddb6978cb2a352e1226ccb74bd2": "failed"
      }, 
      "culprit": "c3cb7d84db9a7d99ae917f32c1acca0f44ca3b22", 
      "metadata": {
        "use_bisect": true, 
        "regression_range_size": 12, 
        "sub_ranges": [
          [
            null, 
            "c3cb7d84db9a7d99ae917f32c1acca0f44ca3b22", 
            "e5ec3568878feddb6978cb2a352e1226ccb74bd2", 
            "cba3aa3a044b578b02a8c237f0bde012260fcf9e", 
            "5484f6789849305b5a86787dd9710c0f682e77e0", 
            "38c960952a3a5b5988c6bbae897451065202d250", 
            "a1f25a6c5efe6eaf1f5fd5d32593f60e4586e6fe", 
            "5f6c9c530b8cda7429c2ca86655439b5ea952b40", 
            "a46782374d15333661c7d3295f7c7413af92b4c0", 
            "42561dc4b39708c610a0149fb61b6f17c0e21f8e", 
            "815054b5918e1d631c4208b06b83d1e833ef6240", 
            "58e4a73d8f76c0683d60cca2a487e88090b05fce", 
            "066ce03b77d3f3802a67e59811f07c9e5fc3e8ab"
          ]
        ]
      }
    }, 
    "url": "http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_variable_chrome/builds/85", 
    "try_job_id": "8984916523849423152"
  },
  {
    "report": {
      "result": {
        "5484f6789849305b5a86787dd9710c0f682e77e0": "failed", 
        "5f6c9c530b8cda7429c2ca86655439b5ea952b40": "failed", 
        "c3cb7d84db9a7d99ae917f32c1acca0f44ca3b22": "failed", 
        "e5ec3568878feddb6978cb2a352e1226ccb74bd2": "failed"
      }, 
      "culprit": "c3cb7d84db9a7d99ae917f32c1acca0f44ca3b22", 
      "metadata": {
        "use_bisect": true, 
        "regression_range_size": 12, 
        "sub_ranges": [
          [
            null, 
            "c3cb7d84db9a7d99ae917f32c1acca0f44ca3b22", 
            "e5ec3568878feddb6978cb2a352e1226ccb74bd2", 
            "cba3aa3a044b578b02a8c237f0bde012260fcf9e", 
            "5484f6789849305b5a86787dd9710c0f682e77e0", 
            "38c960952a3a5b5988c6bbae897451065202d250", 
            "a1f25a6c5efe6eaf1f5fd5d32593f60e4586e6fe", 
            "5f6c9c530b8cda7429c2ca86655439b5ea952b40", 
            "a46782374d15333661c7d3295f7c7413af92b4c0", 
            "42561dc4b39708c610a0149fb61b6f17c0e21f8e", 
            "815054b5918e1d631c4208b06b83d1e833ef6240", 
            "58e4a73d8f76c0683d60cca2a487e88090b05fce", 
            "066ce03b77d3f3802a67e59811f07c9e5fc3e8ab"
          ]
        ]
      }
    }, 
    "url": "http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_variable_chrome/builds/84", 
    "try_job_id": "8984939366240509760", 
    "culprit": {
      "compile": {
        "url": "https://codereview.chromium.org/2756713002", 
        "revision": "c3cb7d84db9a7d99ae917f32c1acca0f44ca3b22", 
        "commit_position": 457493, 
        "repo_name": "chromium"
      }
    }
  }, 
  {
    "report": {
      "result": {
        "5484f6789849305b5a86787dd9710c0f682e77e0": "failed", 
        "5f6c9c530b8cda7429c2ca86655439b5ea952b40": "failed", 
        "c3cb7d84db9a7d99ae917f32c1acca0f44ca3b22": "failed", 
        "e5ec3568878feddb6978cb2a352e1226ccb74bd2": "failed"
      }, 
      "culprit": "c3cb7d84db9a7d99ae917f32c1acca0f44ca3b22", 
      "metadata": {
        "use_bisect": true, 
        "regression_range_size": 12, 
        "sub_ranges": [
          [
            null, 
            "c3cb7d84db9a7d99ae917f32c1acca0f44ca3b22", 
            "e5ec3568878feddb6978cb2a352e1226ccb74bd2", 
            "cba3aa3a044b578b02a8c237f0bde012260fcf9e", 
            "5484f6789849305b5a86787dd9710c0f682e77e0", 
            "38c960952a3a5b5988c6bbae897451065202d250", 
            "a1f25a6c5efe6eaf1f5fd5d32593f60e4586e6fe", 
            "5f6c9c530b8cda7429c2ca86655439b5ea952b40", 
            "a46782374d15333661c7d3295f7c7413af92b4c0", 
            "42561dc4b39708c610a0149fb61b6f17c0e21f8e", 
            "815054b5918e1d631c4208b06b83d1e833ef6240", 
            "58e4a73d8f76c0683d60cca2a487e88090b05fce", 
            "066ce03b77d3f3802a67e59811f07c9e5fc3e8ab"
          ]
        ]
      }
    }, 
    "url": "http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_variable_chrome/builds/85", 
    "try_job_id": "8984916523849423152"
  }
]

 As showed the updated results were at the beginning of the list: which will prevent us from getting the culprit in result page. 
 
Project Member

Comment 1 by bugdroid1@chromium.org, Mar 17 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/infra/+/d1a128a62e7359a8e4bb74e3f920e019eff83782

commit d1a128a62e7359a8e4bb74e3f920e019eff83782
Author: Chan <chanli@chromium.org>
Date: Fri Mar 17 18:46:13 2017

[Findit] Fix bug when update try job results with culprit information.

Before we only check if the last one in try job result is the current one,
but in reruns sometime 2 try jobs are running at the same time and that will cause
redundant data in try job result. To prevent that, we need to check the whole list instead.

BUG= 702690 

Change-Id: I342c7896b84ae6311e7ab6557c626563b7d61a65
Reviewed-on: https://chromium-review.googlesource.com/456590
Reviewed-by: Shuotao Gao <stgao@chromium.org>
Commit-Queue: Chan Li <chanli@chromium.org>

[modify] https://crrev.com/d1a128a62e7359a8e4bb74e3f920e019eff83782/appengine/findit/waterfall/identify_try_job_culprit_pipeline.py

Comment 2 by chanli@chromium.org, Mar 20 2017

Status: Fixed (was: Available)

Sign in to add a comment