Issue 702689 link

Starred by 1 user

Issue metadata

Status:	Archived
Owner:	xiy...@chromium.org
Closed:	Mar 2017
Cc:	jamescook@chromium.org mustash-bugs@google.com
EstimatedDays:	----
NextAction:	----
OS:	Chrome
Pri:	2
Type:	Bug
Proj-Mustash-Mash VerifyIn-60 VerifyIn-61

mash: Support hidpi avatar image

Project Member Reported by xiy...@chromium.org, Mar 17 2017

Issue description

Current code is passing the 1x representation in SessionManagerClient [1]:

  session->avatar = *user.GetImage().bitmap();

We need a way to handle other scale factors, esp. for the bundled avatar images. File this bug to track the TODO.

[1]:
https://cs.chromium.org/chromium/src/chrome/browser/ui/ash/session_controller_client.cc?rcl=4224a22a5cecb204a7eb05b0117ce7080571d24a&l=66

Project Member

Comment 1 by bugdroid1@chromium.org, Mar 27 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/fda72a9f6483a0cf08aa68091eb8f8af464bec64

commit fda72a9f6483a0cf08aa68091eb8f8af464bec64
Author: xiyuan <xiyuan@chromium.org>
Date: Mon Mar 27 17:04:31 2017

ash: HiDPI user avatar for SessionController

- Add mojo structs for ImageSkia and ImageSkiaRep;
- Use ImageSkia instead of SkBitmap for user avatar;

BUG= 702689 ,  655874 
TBR=ben@chromium.org

Review-Url: https://codereview.chromium.org/2770693002
Cr-Commit-Position: refs/heads/master@{#459804}

[modify] https://crrev.com/fda72a9f6483a0cf08aa68091eb8f8af464bec64/ash/common/system/user/tray_user.cc
[modify] https://crrev.com/fda72a9f6483a0cf08aa68091eb8f8af464bec64/ash/common/system/user/user_card_view.cc
[modify] https://crrev.com/fda72a9f6483a0cf08aa68091eb8f8af464bec64/ash/public/interfaces/BUILD.gn
[modify] https://crrev.com/fda72a9f6483a0cf08aa68091eb8f8af464bec64/ash/public/interfaces/session_controller.mojom
[modify] https://crrev.com/fda72a9f6483a0cf08aa68091eb8f8af464bec64/chrome/browser/ui/ash/session_controller_client.cc
[modify] https://crrev.com/fda72a9f6483a0cf08aa68091eb8f8af464bec64/ui/gfx/BUILD.gn
[add] https://crrev.com/fda72a9f6483a0cf08aa68091eb8f8af464bec64/ui/gfx/image/mojo/BUILD.gn
[add] https://crrev.com/fda72a9f6483a0cf08aa68091eb8f8af464bec64/ui/gfx/image/mojo/DEPS
[add] https://crrev.com/fda72a9f6483a0cf08aa68091eb8f8af464bec64/ui/gfx/image/mojo/OWNERS
[add] https://crrev.com/fda72a9f6483a0cf08aa68091eb8f8af464bec64/ui/gfx/image/mojo/image.mojom
[add] https://crrev.com/fda72a9f6483a0cf08aa68091eb8f8af464bec64/ui/gfx/image/mojo/image.typemap
[add] https://crrev.com/fda72a9f6483a0cf08aa68091eb8f8af464bec64/ui/gfx/image/mojo/image_skia_struct_traits.cc
[add] https://crrev.com/fda72a9f6483a0cf08aa68091eb8f8af464bec64/ui/gfx/image/mojo/image_skia_struct_traits.h
[add] https://crrev.com/fda72a9f6483a0cf08aa68091eb8f8af464bec64/ui/gfx/image/mojo/image_traits_test_service.mojom
[add] https://crrev.com/fda72a9f6483a0cf08aa68091eb8f8af464bec64/ui/gfx/image/mojo/image_traits_unittest.cc
[modify] https://crrev.com/fda72a9f6483a0cf08aa68091eb8f8af464bec64/ui/gfx/typemaps.gni