DesktopWindowTreeHostX11HighDPITest.LocatedEventDispatchWithCapture is flaky |
|||
Issue description
Chrome Version: tip
OS: Linux x86-64
What steps will reproduce the problem?
(1) Compile views_unittests:
$ gn gen out/gn '--args=is_debug=false symbol_level=1 use_goma=true' --check
$ time -p ninja -C out/gn views_unittests
(2) Run the test, may be a few times, like 5 or 10, until the failure is observed:
$ ./out/gn/views_unittests --gtest_filter=DesktopWindowTreeHostX11HighDPITest.LocatedEventDispatchWithCapture
IMPORTANT DEBUGGING NOTE: batches of tests are run inside their
own process. For debugging a test inside a debugger, use the
--gtest_filter=<your_test_name> flag along with
--single-process-tests.
Using sharding settings from environment. This is shard 0/1
Using 1 parallel jobs.
Note: Google Test filter = DesktopWindowTreeHostX11HighDPITest.LocatedEventDispatchWithCapture
[==========] Running 1 test from 1 test case.
[----------] Global test environment set-up.
[----------] 1 test from DesktopWindowTreeHostX11HighDPITest
[ RUN ] DesktopWindowTreeHostX11HighDPITest.LocatedEventDispatchWithCapture
../../ui/views/widget/desktop_aura/desktop_window_tree_host_x11_unittest.cc:644: Failure
Value of: second_recorder.mouse_events()[0].location().ToString()
Actual: "-25,-11"
Expected: gfx::Point(-25, -25).ToString()
Which is: "-25,-25"
[ FAILED ] DesktopWindowTreeHostX11HighDPITest.LocatedEventDispatchWithCapture (95 ms)
[----------] 1 test from DesktopWindowTreeHostX11HighDPITest (95 ms total)
[----------] Global test environment tear-down
[==========] 1 test from 1 test case ran. (95 ms total)
[ PASSED ] 0 tests.
[ FAILED ] 1 test, listed below:
[ FAILED ] DesktopWindowTreeHostX11HighDPITest.LocatedEventDispatchWithCapture
1 FAILED TEST
[1/1] DesktopWindowTreeHostX11HighDPITest.LocatedEventDispatchWithCapture (95 ms)
1 test failed:
DesktopWindowTreeHostX11HighDPITest.LocatedEventDispatchWithCapture (../../ui/views/widget/desktop_aura/desktop_window_tree_host_x11_unittest.cc:596)
The issue is first observed on CFI Linux ToT bot:
https://build.chromium.org/p/chromium.fyi/builders/CFI%20Linux%20ToT/builds/5837
It's not related to CFI, as I was able to reproduce it with a regular build. Tentatively assigning to sky@ who changed ui/views/widget/desktop_aura/ the last. Scott, please, find a better owner for the bug, if you feel that your change is irrelevant to this flakiness.
This issue keeps a few buildbots switching from red to green, at least in CFI / LTO land, but given that the failure is not related to these configurations, possibly other buildbots too.
,
Mar 20 2017
This is still a problem for the bots. See, for example, https://build.chromium.org/p/chromium.fyi/builders/CFI%20Linux%20Full/builds/1633
,
Mar 20 2017
I have verified that it still happens in non-CFI builds too: $ gn gen out/gn '--args=is_debug=false symbol_level=1 use_goma=true' --check $ time -p ninja -C out/gn/ views_unittests -j1000 $ ./out/gn/views_unittests --gtest_filter=DesktopWindowTreeHostX11HighDPITest.LocatedEventDispatchWithCapture IMPORTANT DEBUGGING NOTE: batches of tests are run inside their own process. For debugging a test inside a debugger, use the --gtest_filter=<your_test_name> flag along with --single-process-tests. Using sharding settings from environment. This is shard 0/1 Using 1 parallel jobs. Note: Google Test filter = DesktopWindowTreeHostX11HighDPITest.LocatedEventDispatchWithCapture [==========] Running 1 test from 1 test case. [----------] Global test environment set-up. [----------] 1 test from DesktopWindowTreeHostX11HighDPITest [ RUN ] DesktopWindowTreeHostX11HighDPITest.LocatedEventDispatchWithCapture ../../ui/views/widget/desktop_aura/desktop_window_tree_host_x11_unittest.cc:644: Failure Value of: second_recorder.mouse_events()[0].location().ToString() Actual: "-25,-11" Expected: gfx::Point(-25, -25).ToString() Which is: "-25,-25" [ FAILED ] DesktopWindowTreeHostX11HighDPITest.LocatedEventDispatchWithCapture (91 ms) [----------] 1 test from DesktopWindowTreeHostX11HighDPITest (91 ms total) [----------] Global test environment tear-down [==========] 1 test from 1 test case ran. (91 ms total) [ PASSED ] 0 tests. [ FAILED ] 1 test, listed below: [ FAILED ] DesktopWindowTreeHostX11HighDPITest.LocatedEventDispatchWithCapture It's unclear why don't we see this issue on non-CFI/non-LTO bots.
,
Mar 20 2017
... aand the answer is that we actually have it failing on non-CFI bots too, it's always retried and succeeds on the retry: https://luci-logdog.appspot.com/v/?s=chromium%2Fbb%2Fchromium.linux%2FLinux_Tests%2F53450%2F%2B%2Frecipes%2Fsteps%2Fviews_unittests%2F0%2Fstdout Retrying 1 test (retry #1) [891/891] DesktopWindowTreeHostX11HighDPITest.LocatedEventDispatchWithCapture (25 ms) SUCCESS: all tests passed. So, the test is broken everywhere, just in the case of LTO/CFI it happens to fail with enough probability to defeat retries most of the time. I will disable this test on all bots until further investigation.
,
Mar 20 2017
+erg
,
Mar 20 2017
A CL that disables the test case is sent for a review: https://codereview.chromium.org/2759183002/
,
Mar 20 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/258b8078a7855588f6ee9ac0b18c6b1ded9bc58c commit 258b8078a7855588f6ee9ac0b18c6b1ded9bc58c Author: krasin <krasin@chromium.org> Date: Mon Mar 20 17:34:15 2017 Disable LocatedEventDispatchWithCapture test case in views_unittests. It's very flaky and on some bots even defeats 3 retries most of the time. BUG=702687 Review-Url: https://codereview.chromium.org/2759183002 Cr-Commit-Position: refs/heads/master@{#458111} [modify] https://crrev.com/258b8078a7855588f6ee9ac0b18c6b1ded9bc58c/ui/views/widget/desktop_aura/desktop_window_tree_host_x11_unittest.cc
,
Mar 9 2018
Un-cc-ing me from all bugs on my final day. |
|||
►
Sign in to add a comment |
|||
Comment 1 by sky@chromium.org
, Mar 17 2017Status: Assigned (was: Untriaged)