New issue
Advanced search Search tips

Issue 702683 link

Starred by 1 user
Status: Fixed
Owner:
xingliu@chromium.org
Closed: Apr 2017
Cc:
qin...@chromium.org
dtrainor@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug



Sign in to add a comment

Handle early and late server response for parallel download.

Project Member Reported by xingliu@chromium.org, Mar 17 2017 
Currently we have an issue:

the server response, (the byte stream and request handle) may arrive 

1. Too early, i.e. When the user pause the download. and byte stream comes, we should pause from the request handle.

2. Too late, i.e, When the download file is destroy and byte stream comes, we should cancel the request.
Project Member

Comment 1 by bugdroid1@chromium.org, Mar 27 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/cca0315b59850a2d21409f77e6c9c970cb8a47e2

commit cca0315b59850a2d21409f77e6c9c970cb8a47e2
Author: xingliu <xingliu@chromium.org>
Date: Mon Mar 27 20:54:23 2017

Handle early pause, cancel for parallel requests.

Currently we have an issue that Pause, Cancel can be called before
building the parallel requests or before adding the byte stream reader
to the file sink.

In this case, we should still call request handle's pause or cancel to
block the pipe or destroy the pipe.

BUG= 702683 , 644352

Review-Url: https://codereview.chromium.org/2767593003
Cr-Commit-Position: refs/heads/master@{#459873}

[modify] https://crrev.com/cca0315b59850a2d21409f77e6c9c970cb8a47e2/content/browser/download/download_job.cc
[modify] https://crrev.com/cca0315b59850a2d21409f77e6c9c970cb8a47e2/content/browser/download/download_job.h
[modify] https://crrev.com/cca0315b59850a2d21409f77e6c9c970cb8a47e2/content/browser/download/download_worker.cc
[modify] https://crrev.com/cca0315b59850a2d21409f77e6c9c970cb8a47e2/content/browser/download/download_worker.h
[modify] https://crrev.com/cca0315b59850a2d21409f77e6c9c970cb8a47e2/content/browser/download/parallel_download_job.cc
[modify] https://crrev.com/cca0315b59850a2d21409f77e6c9c970cb8a47e2/content/browser/download/parallel_download_job.h
[modify] https://crrev.com/cca0315b59850a2d21409f77e6c9c970cb8a47e2/content/browser/download/parallel_download_job_unittest.cc

Comment 2 by xingliu@chromium.org, Apr 6 2017

Status: Fixed (was: Assigned)
►

Sign in to add a comment