New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 702676 link

Starred by 1 user

Issue metadata

Status: WontFix
Owner:
Last visit > 30 days ago
Closed: Sep 2017
Cc:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug-Regression



Sign in to add a comment

3.7%-4.4% regression in thread_times.key_silk_cases at 457217:457347

Project Member Reported by rmcilroy@chromium.org, Mar 17 2017

Issue description

See the link to graphs below.
 
Project Member

Comment 3 by 42576172...@developer.gserviceaccount.com, Mar 18 2017

Cc: jri@chromium.org
Owner: jri@chromium.org

=== Auto-CCing suspected CL author jri@chromium.org ===

Hi jri@chromium.org, the bisect results pointed to your CL, please take a look at the
results.


=== BISECT JOB RESULTS ===
Perf regression found with culprit

Suspected Commit
  Author : jri
  Commit : c330c07ed723c949ee40db5ce69b57370a93ba2f
  Date   : Thu Mar 16 00:09:53 2017
  Subject: Landing Recent QUIC changes until 18:17, Mar 13, 2017, UTC.

Bisect Details
  Configuration: android_nexus5_perf_bisect
  Benchmark    : thread_times.simple_mobile_sites
  Metric       : thread_IO_cpu_time_per_frame/thread_IO_cpu_time_per_frame
  Change       : 3.97% | 3.18583599993 -> 3.31233894624

Revision             Result                   N
chromium@457225      3.18584 +- 0.286061      14      good
chromium@457256      3.21724 +- 0.157805      13      good
chromium@457271      3.24155 +- 0.52746       14      good
chromium@457272      3.25975 +- 0.231657      9       good
chromium@457273      3.36524 +- 0.059197      6       bad       <--
chromium@457276      3.31992 +- 0.460087      21      bad
chromium@457279      3.33903 +- 0.24626       14      bad
chromium@457286      3.31737 +- 0.385811      14      bad
chromium@457346      3.31234 +- 0.221281      9       bad

To Run This Test
  src/tools/perf/run_benchmark -v --browser=android-chromium --output-format=chartjson --upload-results --pageset-repeat=1 --also-run-disabled-tests thread_times.simple_mobile_sites

Debug Info
  https://chromeperf.appspot.com/buildbucket_job_status/8984856632363577296

Is this bisect wrong?
  https://chromeperf.appspot.com/bad_bisect?try_job_id=4585271141597184


| O O | Visit http://www.chromium.org/developers/speed-infra/perf-bug-faq
|  X  | for more information addressing perf regression bugs. For feedback,
| / \ | file a bug with component Speed>Bisection.  Thank you!

Comment 4 by jri@chromium.org, Mar 18 2017

Cc: rch@chromium.org
I don't think this CL is the culprit. All changes are could matter in this CL should be flagged off as far as I can tell. (I'm rushing right now and will be without network connectivity until late Sunday, so Cc'ing rch@ if there's anything urgent to be done here.)
Project Member

Comment 6 by 42576172...@developer.gserviceaccount.com, Mar 20 2017


=== BISECT JOB RESULTS ===
Perf regression found but unable to narrow commit range

Build failures prevented the bisect from narrowing the range further.


Bisect Details
  Configuration: android_nexus5_perf_bisect
  Benchmark    : thread_times.key_silk_cases
  Metric       : thread_IO_cpu_time_per_frame/thread_IO_cpu_time_per_frame

Suspected Commit Range
  16 commits in range
  https://chromium.googlesource.com/chromium/src/+log/002b2ee07c580e92cefa2fbc7c067af40c367c44..61cec5005c6a5f6cb0e0ebdc404c442797af126e


Revision             Result                    N
chromium@457216      3.49126 +- 0.0480324      6        good
chromium@457249      3.49214 +- 0.0579178      6        good
chromium@457266      3.51367 +- 0.0586421      6        good
chromium@457267      ---                       ---      build failure
---                  ---                       ---      too many build failures to list
chromium@457281      ---                       ---      build failure
chromium@457282      3.67471 +- 0.0520753      6        bad
chromium@457347      3.60686 +- 0.0918762      6        bad

To Run This Test
  src/tools/perf/run_benchmark -v --browser=android-chromium --output-format=chartjson --upload-results --pageset-repeat=1 --also-run-disabled-tests thread_times.key_silk_cases

Debug Info
  https://chromeperf.appspot.com/buildbucket_job_status/8984668933207799248

Is this bisect wrong?
  https://chromeperf.appspot.com/bad_bisect?try_job_id=6120746377543680


| O O | Visit http://www.chromium.org/developers/speed-infra/perf-bug-faq
|  X  | for more information addressing perf regression bugs. For feedback,
| / \ | file a bug with component Speed>Bisection.  Thank you!
Status: Assigned (was: Untriaged)
Explictly assigning. A CL you landed tripped one of the speed metrics we measure in the lab. If this is the first time this has happened to one of your CLs, or if it's been a while, please read: https://chromium.googlesource.com/chromium/src/+/master/docs/speed/addressing_performance_regressions.md

We're looking for one of the following:
1. Justification via explanation
2. Plan to revert or fix
3. Angry rage throwing of equipment at my head

Just be aware that I'm trained in trumpet playing and First Aid and am not afraid to use it.

Note: This was a bulk edit message and not very personal.
Status: WontFix (was: Assigned)
These have all dropped back down since the initial regression.

Sign in to add a comment