New issue
Advanced search Search tips

Issue 702659 link

Starred by 3 users

Issue metadata

Status: Fixed
Owner:
Closed: Dec 2017
Cc:
Components:
EstimatedDays: ----
NextAction: 2017-04-18
OS: Chrome
Pri: 2
Type: Bug
Team-Accessibility

Blocking:
issue 683396



Sign in to add a comment

[ARC++ A11y] Support custom actions

Project Member Reported by lpalmaro@chromium.org, Mar 17 2017

Issue description

OS: Chrome

This bug is to track the work to support custom actions in ChromeVox which will include standard actions on Android not available in ChromeVox. This will require adding a list of supported actions to AccessibilityNodeInfoData (mojo object).
On the ChromeVox end, we will need to add some affordance to show and select the desired action (e.g. add a menu in the ChromeVox Panel to show all currently available actions).

 
Components: UI>Accessibility
Labels: NewComponent-Accessibility NewComponent-Accessibility-ChromeVox
Owner: yawano@chromium.org
Hi Yuki, do you think you could tackle this one? Maybe you can hook up the actions in our idl's and if you'd like, hook up a new actions menu in the ChromeVox Panel. I can do the latter if this sounds like too much.
Cc: dtseng@chromium.org
Yes. Which is the targeted milestone? Is M60 okay? I won't be able to immediately start working on this item.

Comment 5 by dtseng@chromium.org, Apr 18 2017

NextAction: 2017-04-18
m60 sounds great!

Comment 6 by dtseng@chromium.org, Apr 18 2017

Labels: M-60
Components: UI>Accessibility>ChromeVox
Labels: -newcomponent-accessibility -newcomponent-accessibility-chromevox
Components: -UI>Accessibility
My plan is to add a new top level item "custom actions" in ChromeVox panel, and add custom actions there. We might be able to assign new keyboard shortcut to open the menu quickly.

David, WDYT?
Blocking: 683396
Project Member

Comment 11 by bugdroid1@chromium.org, Jun 26 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b87aed4000a7e2824a8146891cc733bba653879c

commit b87aed4000a7e2824a8146891cc733bba653879c
Author: yawano <yawano@chromium.org>
Date: Mon Jun 26 02:55:29 2017

Add custom action support

- This CL extends chrome.automation API to support custom actions.
- Proposal to extend chrome.automation API:
  https://docs.google.com/document/d/1Gw-2kyCF5AoPotX9V3A0sWtrrSlatVxEdtFOEnSGM_U/edit
- This CL implements custom action support in Android windows. Note that
  we need to land Android side CL as well.

BUG= 702659 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2873373005
Cr-Commit-Position: refs/heads/master@{#482187}

[modify] https://crrev.com/b87aed4000a7e2824a8146891cc733bba653879c/chrome/browser/chromeos/arc/accessibility/arc_accessibility_helper_bridge.cc
[modify] https://crrev.com/b87aed4000a7e2824a8146891cc733bba653879c/chrome/browser/chromeos/arc/accessibility/ax_tree_source_arc.cc
[modify] https://crrev.com/b87aed4000a7e2824a8146891cc733bba653879c/chrome/browser/extensions/api/automation_internal/automation_internal_api.cc
[modify] https://crrev.com/b87aed4000a7e2824a8146891cc733bba653879c/chrome/browser/resources/chromeos/chromevox/cvox2/background/panel.js
[modify] https://crrev.com/b87aed4000a7e2824a8146891cc733bba653879c/chrome/browser/resources/chromeos/chromevox/strings/chromevox_strings.grd
[modify] https://crrev.com/b87aed4000a7e2824a8146891cc733bba653879c/chrome/common/extensions/api/automation.idl
[modify] https://crrev.com/b87aed4000a7e2824a8146891cc733bba653879c/chrome/common/extensions/api/automation_internal.idl
[modify] https://crrev.com/b87aed4000a7e2824a8146891cc733bba653879c/chrome/common/extensions/chrome_extension_messages.h
[modify] https://crrev.com/b87aed4000a7e2824a8146891cc733bba653879c/chrome/renderer/extensions/automation_internal_custom_bindings.cc
[modify] https://crrev.com/b87aed4000a7e2824a8146891cc733bba653879c/chrome/renderer/resources/extensions/automation/automation_node.js
[modify] https://crrev.com/b87aed4000a7e2824a8146891cc733bba653879c/components/arc/common/accessibility_helper.mojom
[modify] https://crrev.com/b87aed4000a7e2824a8146891cc733bba653879c/content/public/common/common_param_traits_macros.h
[modify] https://crrev.com/b87aed4000a7e2824a8146891cc733bba653879c/content/renderer/accessibility/render_accessibility_impl.cc
[modify] https://crrev.com/b87aed4000a7e2824a8146891cc733bba653879c/third_party/closure_compiler/externs/automation.js
[modify] https://crrev.com/b87aed4000a7e2824a8146891cc733bba653879c/ui/accessibility/ax_action_data.cc
[modify] https://crrev.com/b87aed4000a7e2824a8146891cc733bba653879c/ui/accessibility/ax_action_data.h
[modify] https://crrev.com/b87aed4000a7e2824a8146891cc733bba653879c/ui/accessibility/ax_enums.idl
[modify] https://crrev.com/b87aed4000a7e2824a8146891cc733bba653879c/ui/accessibility/ax_node_data.cc
[modify] https://crrev.com/b87aed4000a7e2824a8146891cc733bba653879c/ui/accessibility/ax_node_data.h
[modify] https://crrev.com/b87aed4000a7e2824a8146891cc733bba653879c/ui/accessibility/ax_tree.cc
[modify] https://crrev.com/b87aed4000a7e2824a8146891cc733bba653879c/ui/accessibility/ax_tree.h

Status: fixed (was: Assigned)
I believe this is done; re-open if there's anything remaining.

Sign in to add a comment