Laser pointer support in ash does not work with mus |
|||||||
Issue descriptionmus+ash does not have access to a ContextFactoryPrivate instance. The code in //ash/laser needs access to it [1]. So this code currently crashes in mash. The relevant tests (LaserPointerControllerTest) also crash. 1: https://cs.chromium.org/chromium/src/ash/laser/laser_pointer_view.cc?type=cs&sq=package:chromium&l=211
,
Mar 17 2017
My bad. Feel free to assign this to me and I'll update it to work with mus asap.
,
Mar 17 2017
That would be awesome! :) Thanks!
,
May 8 2017
/cc+ penghuang@ Maybe you can take this after https://codereview.chromium.org/2868473002/ lands?
,
May 8 2017
Sorry for not getting to this. If someone like who's more familiar with mash could take a look at this then that would be great! Otherwise, I'll of course try to get to this asap.
,
May 8 2017
,
May 10 2017
,
Aug 1 2017
,
Nov 2 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/f4871ce31ea30e007745435a2944ae6da198f598 commit f4871ce31ea30e007745435a2944ae6da198f598 Author: James Cook <jamescook@chromium.org> Date: Thu Nov 02 20:29:30 2017 cros: Enable LaserPointerControllerTest under --mash Blocking bug was fixed a while ago, test passes now. Bug: 702657 Test: ash_unittests --mash Change-Id: Id94f13bfaad45cf186ff21a44ab718dfaf13c4f1 Reviewed-on: https://chromium-review.googlesource.com/751773 Reviewed-by: Steven Bennetts <stevenjb@chromium.org> Commit-Queue: James Cook <jamescook@chromium.org> Cr-Commit-Position: refs/heads/master@{#513593} [modify] https://crrev.com/f4871ce31ea30e007745435a2944ae6da198f598/ash/laser/laser_pointer_controller_unittest.cc
,
Jan 22 2018
,
Feb 26 2018
|
|||||||
►
Sign in to add a comment |
|||||||
Comment 1 by sky@chromium.org
, Mar 17 2017