New issue
Advanced search Search tips
Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Mar 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 3
Type: Bug



Sign in to add a comment

Replace MediaWebContentsObserver::HasActiveEffectivelyFullscreenVideo DCHECK with early return

Project Member Reported by mlamouri@chromium.org, Mar 17 2017 Back to list

Issue description

The only caller for this method has changed and no longer check for fullscreen, fully relying on this method to return false when not fullscreen. Updating the fullscreen check to follow that reality.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Mar 20 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/fc7f323f548c926b99fe6ebd15f46a514f0df198

commit fc7f323f548c926b99fe6ebd15f46a514f0df198
Author: mlamouri <mlamouri@chromium.org>
Date: Mon Mar 20 20:25:24 2017

Media: replace HasActiveEffectivelyFullscreenVideo DCHECK with early return.

BUG= 702647 
R=chcunningham@chromium.org

Review-Url: https://codereview.chromium.org/2759713002
Cr-Commit-Position: refs/heads/master@{#458167}

[modify] https://crrev.com/fc7f323f548c926b99fe6ebd15f46a514f0df198/content/browser/media/media_web_contents_observer.cc

Labels: -M-58 M-59
Status: Fixed (was: Started)
No need to merge this, it should have no impact on release builds.

Comment 3 by dah...@chromium.org, Mar 29 2017

Blocking: -679364

Sign in to add a comment