[A11y Assessment - NTP] Mic icon on NTP needs to be marked up as a button |
|||||||
Issue descriptionOS: all desktop When you navigate to the NTP and use a screen reader to get to the mic icon, you hear spoken feedback -- on Mac, you hear "say ok Google" and on Chrome OS you hear "listening for ok Google". But you don't hear that this is a button. We need to make sure that this is properly marked up as a button so that the screen reader can tell users it's clickable.
,
Apr 21 2017
,
Sep 7 2017
Chrome 63.0.3208.0 (Official Build) canary (64-bit) (cohort: 64-Bit) Windows 10 Enterprise Version 10.0.14393 Build 14393 NVDA 2017.3 JAWS 2018 Beta ChromeOS Version 62.0.3201.0 (Official Build) canary (64-bit) I am able to repro this issue. Windows with NVDA: "Clickable Search by Voice" Windows with JAWS: "Search by Voice" ChromeVox with ChromeOS: "Search by Voice Form", when tabbing away, it says "Exited Form"
,
Nov 3 2017
I believe this is fixed on the local NTP (which we're planning to launch in M64). Chris, can you confirm?
,
Nov 3 2017
,
Nov 3 2017
It's in the CQ. VoiceOver (Mac) will announce it as "Search by voice, button" but I haven't checked with Windows or ChromeVox and don't have those devices handy to check.
,
Nov 3 2017
Awesome! Let's just ping this bug once it's in Canary, then the reporter can re-check.
,
Nov 3 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/0470ec91fcfb28b00865ae502d55efde064a666d commit 0470ec91fcfb28b00865ae502d55efde064a666d Author: Chris Pickel <sfiera@chromium.org> Date: Fri Nov 03 11:26:15 2017 Local NTP: use button#fakebox-microphone As a button, it's naturally tabbable, and is announced by VoiceOver as a "Search by voice, button" instead of as a "group" (div). Bug: 702642 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I1670933e2bfca1335fe9d76a719947a0e0a55142 Reviewed-on: https://chromium-review.googlesource.com/741234 Commit-Queue: Chris Pickel <sfiera@chromium.org> Reviewed-by: Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#513742} [modify] https://crrev.com/0470ec91fcfb28b00865ae502d55efde064a666d/chrome/browser/resources/local_ntp/local_ntp.css [modify] https://crrev.com/0470ec91fcfb28b00865ae502d55efde064a666d/chrome/browser/resources/local_ntp/local_ntp.html [modify] https://crrev.com/0470ec91fcfb28b00865ae502d55efde064a666d/chrome/test/data/local_ntp/local_ntp_browsertest.html
,
Nov 29 2017
This should be fixed now, and it's been in Canary/Dev for a while. To test: Enable chrome://flags/#use-google-local-ntp and chrome://flags/#voice-search-on-local-ntp and restart Chrome as prompted, then open an NTP as usual.
,
Jan 17 2018
|
|||||||
►
Sign in to add a comment |
|||||||
Comment 1 by dmazz...@chromium.org
, Mar 27 2017