Chrome not responding when showing an alert with large text |
||||||||
Issue description
Chrome Version: Version 59.0.3044.0
OS: Mac 10.12.2
Precondition:
Goto chrome://flags
Enable the below flag
Material Design in the rest of the browser's native UI Mac, Windows, Linux, Chrome OS
Extends the --top-chrome-md setting to secondary UI (bubbles, dialogs, etc.). On Mac, this enables MacViews, which uses toolkit-views for native browser dialogs. #secondary-ui-md
Relaunch browser
Steps to reproduce:
Create a HTML page with the below code
Launch the html in chrome
Chrome is not Not Responding
Need to Force Quit and launch agian
Works fine if the flag above is disabled.
<!DOCTYPE html>
<html>
<head>
<meta charset="utf-8">
<meta name="viewport" content="width=device-width">
<title>JS Bin</title>
</head>
<body>
<script>
var text = "Lorem Ipsum is simply dummy text of the printing and typesetting industry. Lorem Ipsum has been the industry's standard dummy text ever since the 1500s, when an unknown printer took a galley of type and scrambled it to make a type specimen book. It has survived not only five centuries, but also the leap into electronic typesetting, remaining essentially unchanged. It was popularised in the 1960s with the release of Letraset sheets containing Lorem Ipsum passages, and more recently with desktop publishing software like Aldus PageMaker including versions of Lorem Ipsum.";
text += text;
text += text;
text += text;
text += text;
text += text;
text += text;
text += text;
text += text;
alert(text)
</script>
</body>
</html>
,
Mar 23 2017
Oh, ouch. This not only hangs the browser, but actually screws up the window manager pretty badly as well (!!). I'll take a look.
,
Mar 28 2017
over to you, avi :)
,
Mar 28 2017
This is a Mac thing. The Views version uses MessageBoxView, which truncates and adds a scrollbar. The Mac version uses ConstrainedWindowAlert, which doesn't truncate or add a scrollbar or anything. :/
,
Mar 29 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/49bcdac7e28c672a3de1b11c70f4164b9582faa7 commit 49bcdac7e28c672a3de1b11c70f4164b9582faa7 Author: avi <avi@chromium.org> Date: Wed Mar 29 04:15:35 2017 Restrict the amount of text shown in dialogs. BUG= 702638 TEST=as in bug Review-Url: https://codereview.chromium.org/2778163004 Cr-Commit-Position: refs/heads/master@{#460274} [modify] https://crrev.com/49bcdac7e28c672a3de1b11c70f4164b9582faa7/chrome/browser/ui/javascript_dialogs/javascript_dialog_tab_helper.cc
,
Mar 29 2017
,
Mar 29 2017
May I merge? This is a functionality bug in dialogs being rolled out now on beta.
,
Mar 30 2017
Your change meets the bar and is auto-approved for M58. Please go ahead and merge the CL to branch 3029 manually. Please contact milestone owner if you have questions. Owners: amineer@(Android), cmasso@(iOS), bhthompson@(ChromeOS), govind@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Mar 30 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/a214aa5ff7c57c2c80df5461cd39538ddf8d4823 commit a214aa5ff7c57c2c80df5461cd39538ddf8d4823 Author: Avi Drissman <avi@chromium.org> Date: Thu Mar 30 14:54:52 2017 Restrict the amount of text shown in dialogs. BUG= 702638 TEST=as in bug Review-Url: https://codereview.chromium.org/2778163004 Cr-Commit-Position: refs/heads/master@{#460274} (cherry picked from commit 49bcdac7e28c672a3de1b11c70f4164b9582faa7) Review-Url: https://codereview.chromium.org/2785193002 . Cr-Commit-Position: refs/branch-heads/3029@{#488} Cr-Branched-From: 939b32ee5ba05c396eef3fd992822fcca9a2e262-refs/heads/master@{#454471} [modify] https://crrev.com/a214aa5ff7c57c2c80df5461cd39538ddf8d4823/chrome/browser/ui/javascript_dialogs/javascript_dialog_tab_helper.cc
,
Mar 30 2017
,
Apr 5 2017
Verified the fix on Mac 10.12.3 using Chrome beta version #58.0.3029.54 as per the comment #0. Observed that the html page got loaded in chrome after enabling the flag "Material Design in the rest of the browser's native UI" without any issues. Hence, the fix is working as expected. Attaching the screencast for reference Adding the verified labels. Thanks...!!
,
Nov 1 2017
LGTM |
||||||||
►
Sign in to add a comment |
||||||||
Comment 1 by erikc...@chromium.org
, Mar 20 2017Status: Assigned (was: Untriaged)