New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 702626 link

Starred by 1 user
Status: Fixed
Owner:
█ awdf@chromium.org
Last visit > 30 days ago
Closed: Apr 2017
Cc:
peter@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 1
Type: Task

Blocking:
issue 702628



Sign in to add a comment

Upstream notification channels code

Project Member Reported by awdf@chromium.org, Mar 17 2017 
From http://crbug/678670 :

- move the createChromeNotificationBuilder() method from AppHooks to a new NotificationBuilderFactory class
- rename NotificationBuilderInternal > NotificaitonBuilderForO
- rename the obfuscated 'categoryId' etc variables to 'channelId' etc for clarity.

This is blocked on the O developer preview being made public (scheduled for 21st March).

Comment 1 by awdf@chromium.org, Mar 17 2017

Blocking: 702628

Comment 2 by nyquist@chromium.org, Mar 22 2017 

Can we remove RVG from this bug now? It doesn't seem like it contains any internal-only information anymore?

Comment 3 by awdf@chromium.org, Mar 22 2017

Labels: -Restrict-View-Google
Project Member

Comment 4 by bugdroid1@chromium.org, Mar 23 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a2876b06705e043a0781ca08019234e396140010

commit a2876b06705e043a0781ca08019234e396140010
Author: awdf <awdf@chromium.org>
Date: Thu Mar 23 12:54:25 2017

[Android O] Upstreaming notification channels code

This is part one which moves where we create the notification builder
from AppHooksImpl to NotificationBuilderFactory.

The AppHooks method will be removed in a further patch.

BUG= 702626 

Review-Url: https://codereview.chromium.org/2765003002
Cr-Commit-Position: refs/heads/master@{#459060}

[modify] https://crrev.com/a2876b06705e043a0781ca08019234e396140010/chrome/android/java/src/org/chromium/chrome/browser/download/DownloadNotificationService.java
[modify] https://crrev.com/a2876b06705e043a0781ca08019234e396140010/chrome/android/java/src/org/chromium/chrome/browser/incognito/IncognitoNotificationManager.java
[modify] https://crrev.com/a2876b06705e043a0781ca08019234e396140010/chrome/android/java/src/org/chromium/chrome/browser/media/MediaCaptureNotificationService.java
[modify] https://crrev.com/a2876b06705e043a0781ca08019234e396140010/chrome/android/java/src/org/chromium/chrome/browser/media/ui/MediaNotificationManager.java
[modify] https://crrev.com/a2876b06705e043a0781ca08019234e396140010/chrome/android/java/src/org/chromium/chrome/browser/notifications/CustomNotificationBuilder.java
[add] https://crrev.com/a2876b06705e043a0781ca08019234e396140010/chrome/android/java/src/org/chromium/chrome/browser/notifications/NotificationBuilderFactory.java
[add] https://crrev.com/a2876b06705e043a0781ca08019234e396140010/chrome/android/java/src/org/chromium/chrome/browser/notifications/NotificationBuilderForO.java
[modify] https://crrev.com/a2876b06705e043a0781ca08019234e396140010/chrome/android/java/src/org/chromium/chrome/browser/notifications/NotificationConstants.java
[modify] https://crrev.com/a2876b06705e043a0781ca08019234e396140010/chrome/android/java/src/org/chromium/chrome/browser/notifications/StandardNotificationBuilder.java
[modify] https://crrev.com/a2876b06705e043a0781ca08019234e396140010/chrome/android/java/src/org/chromium/chrome/browser/ntp/ContentSuggestionsNotificationHelper.java
[modify] https://crrev.com/a2876b06705e043a0781ca08019234e396140010/chrome/android/java/src/org/chromium/chrome/browser/physicalweb/PhysicalWebBroadcastService.java
[modify] https://crrev.com/a2876b06705e043a0781ca08019234e396140010/chrome/android/java/src/org/chromium/chrome/browser/sync/SyncNotificationController.java
[modify] https://crrev.com/a2876b06705e043a0781ca08019234e396140010/chrome/android/java_sources.gni
Project Member

Comment 5 by bugdroid1@chromium.org, Mar 24 2017 

The following revision refers to this bug:
  https://chrome-internal.googlesource.com/clank/internal/apps/+/edf58fd9946efc5a67d853288ca4dd58cacef293

commit edf58fd9946efc5a67d853288ca4dd58cacef293
Author: Anita Woodruff <awdf@google.com>
Date: Fri Mar 24 21:05:16 2017

Comment 6 by awdf@chromium.org, Apr 11 2017 

Part two - https://codereview.chromium.org/2765023002/ - which removes the AppHooks method and renames things - also landed which should have been attached to this bug - not sure why it wasn't.

Comment 7 by awdf@chromium.org, Apr 11 2017

Status: Fixed (was: Started)
►

Sign in to add a comment