New issue
Advanced search Search tips

Issue 702616 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Mar 2017
Components:
EstimatedDays: ----
NextAction: ----
OS: Windows , All
Pri: 3
Type: Bug



Sign in to add a comment

Code cleanup: unnecessary conditional in PaintLayerCompositor

Project Member Reported by smcgruer@chromium.org, Mar 17 2017

Issue description

https://cs.chromium.org/chromium/src/third_party/WebKit/Source/core/layout/compositing/PaintLayerCompositor.cpp?l=417&rcl=1e3b610bfff1acd060ed8b3f595344402b833bad

We early-exit for CompositingUpdateNone on line 375, and the only change to updateType after that is line 410 where it is at most increased. Therefore, with the current code the updateType can't be none at line 417.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Mar 18 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/255379a40c015ed5a5003ff914c0cce5d0893001

commit 255379a40c015ed5a5003ff914c0cce5d0893001
Author: smcgruer <smcgruer@chromium.org>
Date: Sat Mar 18 01:01:39 2017

Code cleanup: remove unnecessary conditional guard in PaintLayerCompositor

We early-exit for CompositingUpdateNone on line 375, and the only change to
updateType after that is line 410 where it is at most increased. Therefore,
with the current code the updateType can't be none at line 417.

BUG= 702616 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2

Review-Url: https://codereview.chromium.org/2756903002
Cr-Commit-Position: refs/heads/master@{#457913}

[modify] https://crrev.com/255379a40c015ed5a5003ff914c0cce5d0893001/third_party/WebKit/Source/core/layout/compositing/PaintLayerCompositor.cpp

Status: Fixed (was: Available)

Sign in to add a comment