New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 702613 link

Starred by 1 user

Issue metadata

Status: Duplicate
Merged: issue 703397
Owner:
Closed: Mar 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Mac
Pri: 1
Type: Bug-Security



Sign in to add a comment

Heap-buffer-overflow in SkColorSpaceXform_XYZ<

Project Member Reported by ClusterFuzz, Mar 17 2017

Issue description

Project Member

Comment 1 by ClusterFuzz, Mar 17 2017

Labels: OS-Linux

Comment 2 by tsepez@chromium.org, Mar 17 2017

 Issue 702633  has been merged into this issue.

Comment 3 by tsepez@chromium.org, Mar 17 2017

Labels: M-58
Owner: caryclark@chromium.org
Status: Assigned (was: Untriaged)
Cary, would you mind taking a look or finding a more appropriate owner?

Comment 4 by tsepez@chromium.org, Mar 17 2017

Components: Internals>Skia
Project Member

Comment 5 by sheriffbot@chromium.org, Mar 18 2017

Labels: -Security_Impact-Head Security_Impact-Beta
Project Member

Comment 6 by sheriffbot@chromium.org, Mar 18 2017

Labels: ReleaseBlock-Stable
Project Member

Comment 7 by sheriffbot@chromium.org, Mar 18 2017

Labels: Pri-1
Owner: msarett@chromium.org
Matt, is this in your code?
Cc: msarett@chromium.org
Owner: scroggo@chromium.org
Yes, the overflow is in my code.

I suspect this change:
https://codereview.chromium.org/2618633004

It's in the blame range and the images from the test case seem to be animated pngs (Cool!).  Reassigning to Leon.

tsepez@ why is this labeled M58?  I think animated png is for M59?
I am unable to see the detailed report as either scroggo@chromium.org or scroggo@google.com. Can someone please give me permission?
Status: Started (was: Assigned)
Though I am unable to see the report, it looks like this may be related to  issue 703397 .

If that is the case, the fix is at https://codereview.chromium.org/2761193003
Mergedinto: 703397
Status: Duplicate (was: Started)
Okay, I'm able to see the report now. This is a dupe.
Project Member

Comment 13 by ClusterFuzz, Mar 23 2017

ClusterFuzz has detected this issue as fixed in range 458620:458734.

Detailed report: https://clusterfuzz.com/testcase?key=4618590008639488

Fuzzer: noel-image-surku
Job Type: mac_asan_chrome
Platform Id: mac

Crash Type: Heap-buffer-overflow READ 4
Crash Address: 0x61200009c174
Crash State:
  SkColorSpaceXform_XYZ<
  blink::PNGImageDecoder::rowAvailable
  cr_png_push_process_row
  
Sanitizer: address (ASAN)

Recommended Security Severity: Medium

Regressed: https://clusterfuzz.com/revisions?job=mac_asan_chrome&range=456626:457730
Fixed: https://clusterfuzz.com/revisions?job=mac_asan_chrome&range=458620:458734

Reproducer Testcase: https://clusterfuzz.com/download/AMIfv97hpKT0V6fvhAynLU9mtrBzIW1GtF6Is8DNrw6Lcvr5hlf7OCJ0EWlH0K-_ovlxwo096Z3tV4XzeUS7Rg9-Wp3xMk1W34gv7_HVPL9oPsIylXBM8vhUjKZO1F4bHGc1MlLQylE-Plu0yRTERBh25ADGvoBTQZZKq4wEqgWHtYMmERPjsP5G-TLDCdWz9hD5ThMoH6xdcU2h43DklJUivgmkrc7P_-YSx4pZej6EY9jEXyLFInfddQ80_Zi4_daeOjHiBGb3vtchjxb1-ioDQ_y54gm1r0JyNE-_1P4LbC0soj3pJtXrMXM21KezJv24223r9nzJnO-mv5Gja85xKIpFoH4Os6LkBnz1-P9a_kQoS7Vdp6g?testcase_id=4618590008639488


See https://dev.chromium.org/Home/chromium-security/bugs/reproducing-clusterfuzz-bugs for more information.

If you suspect that the result above is incorrect, try re-doing that job on the test case report page.
Labels: -ReleaseBlock-Stable -M-58 M-59
Project Member

Comment 15 by sheriffbot@chromium.org, Jun 29 2017

Labels: -Restrict-View-SecurityTeam allpublic
This bug has been closed for more than 14 weeks. Removing security view restrictions.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Sign in to add a comment