New issue
Advanced search Search tips

Issue 702599 link

Starred by 1 user

Issue metadata

Status: Archived
Owner: ----
Closed: Oct 16
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Windows
Pri: 3
Type: Bug



Sign in to add a comment

better support for symbolizing stack traces in minidumps from jitted code

Project Member Reported by jochen@chromium.org, Mar 17 2017

Issue description

We could add a crash key that helps to find the js_entry_sp in minidumps.

We could either use a base::debug::StackTrace in the beforeCallEnteredCallback to get a frame pointer from v8 and store it in a crash key on every call (but that might be prohibitively expensive), or we just expose the address of the Invoke function in execution.cc as a crash key, and on the server side scan the stack for values close to this function and restart symbolizing from there.

thoughts?
 
Cc: mark@chromium.org rsesek@chromium.org
Components: Internals>CrashReporting

Comment 2 by rsesek@chromium.org, Sep 18 2017

Setting a crash key for this seems reasonable. But I don't think we currently use crash keys to influence stack scanning. We do use them to influence the magic signature, though. I'm not sure how hard the former would be off the top of my head.
Labels: Needs-Milestone TE-NeedsTriageHelp
The issue seems to be out of TE-scope as it is related to jitted code. Hence, adding label TE-NeedsTriageHelp for further investigation from dev team.

Thanks...!!
Project Member

Comment 4 by sheriffbot@chromium.org, Oct 16

Status: Archived (was: Unconfirmed)
Issue has not been modified or commented on in the last 365 days, please re-open or file a new bug if this is still an issue.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Sign in to add a comment